Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TR logging when cqhv field is absent #7340

Merged
merged 4 commits into from
Feb 3, 2023

Conversation

srijeet0406
Copy link
Contributor

This PR is not related to any issue. It adds the "-" default value for the "cqhv" field, when it is absent.


Which Traffic Control components are affected by this PR?

  • Traffic Router

What is the best way to verify this PR?

Make sure all the tests pass.
Send in a request with the protocol set to null or an empty string and make sure the logs show cqhv="-".

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@srijeet0406 srijeet0406 marked this pull request as ready for review February 2, 2023 23:28
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #7340 (680931c) into master (9da78ae) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7340   +/-   ##
=========================================
  Coverage     25.02%   25.02%           
  Complexity       98       98           
=========================================
  Files           593      593           
  Lines         73528    73528           
  Branches         90       90           
=========================================
  Hits          18398    18398           
  Misses        53383    53383           
  Partials       1747     1747           
Flag Coverage Δ
traffic_router_unit 29.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zrhoffman zrhoffman added bug something isn't working as intended Traffic Router related to Traffic Router medium impact impacts a significant portion of a CDN, or has the potential to do so logging related to logging infrastructure labels Feb 2, 2023
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zrhoffman zrhoffman merged commit 3aca837 into apache:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended logging related to logging infrastructure medium impact impacts a significant portion of a CDN, or has the potential to do so Traffic Router related to Traffic Router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants