Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t3c remove stale git lock file #7346

Merged
merged 8 commits into from
Feb 10, 2023
Merged

t3c remove stale git lock file #7346

merged 8 commits into from
Feb 10, 2023

Conversation

jpappa200
Copy link
Contributor

When using git to track changes in etc/trafficserver sometimes the lock file isn't cleared and git will stop updating. This PR will cause t3c-apply to look for a lock file that is more than 5 min old and remove if it exists.


Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)

What is the best way to verify this PR?

The best way to verify and to create an index.lock file in /opt/trafficserver/etc/trafficserver/.git/ and tail reval.log and syncds.log when the file is 5 minutes old it will be cleared.

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #7346 (3afd237) into master (3aca837) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #7346      +/-   ##
============================================
- Coverage     25.07%   25.06%   -0.01%     
  Complexity       98       98              
============================================
  Files           593      593              
  Lines         73616    73644      +28     
  Branches         90       90              
============================================
+ Hits          18459    18460       +1     
- Misses        53406    53433      +27     
  Partials       1751     1751              
Flag Coverage Δ
golib_unit 53.16% <ø> (+<0.01%) ⬆️
grove_unit 4.60% <ø> (ø)
t3c_unit 5.33% <0.00%> (-0.03%) ⬇️
traffic_monitor_unit 20.43% <ø> (ø)
traffic_ops_unit 19.70% <ø> (ø)
traffic_stats_unit 10.41% <ø> (ø)
unit_tests 22.59% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cache-config/t3c-apply/t3c-apply.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/util/gitutil.go 0.00% <0.00%> (ø)
lib/go-atscfg/serverunknown.go 79.66% <0.00%> (+1.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocket8888 ocket8888 added low impact affects only a small portion of a CDN, and cannot itself break one cache-config Cache config generation labels Feb 8, 2023
Copy link
Contributor

@traeak traeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me.

@ocket8888 ocket8888 added the bug something isn't working as intended label Feb 10, 2023
@ocket8888 ocket8888 merged commit dad5772 into apache:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended cache-config Cache config generation low impact affects only a small portion of a CDN, and cannot itself break one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants