Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming tm.sameipservers.control to tm.sameipservers.enabled #7431

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

serDrem
Copy link
Contributor

@serDrem serDrem commented Apr 4, 2023

Related: #7302

Renaming tm.sameipservers.control to tm.sameipservers.enabled for clarity

Which Traffic Control components are affected by this PR?

  • Traffic Monitor

What is the best way to verify this PR?

use tm.sameipservers.enabled instead of tm.sameipservers.control to verify functionality in #7302

PR submission checklist

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #7431 (6ce437a) into master (904e240) will increase coverage by 0.64%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7431      +/-   ##
============================================
+ Coverage     27.12%   27.77%   +0.64%     
  Complexity       98       98              
============================================
  Files           685      597      -88     
  Lines         77414    69651    -7763     
  Branches         90       90              
============================================
- Hits          20999    19345    -1654     
+ Misses        54423    48510    -5913     
+ Partials       1992     1796     -196     
Flag Coverage Δ
golib_unit 48.39% <ø> (-0.02%) ⬇️
grove_unit 4.60% <ø> (ø)
t3c_unit 5.32% <ø> (ø)
traffic_monitor_unit ?
traffic_ops_unit 22.19% <ø> (ø)
traffic_stats_unit 10.14% <ø> (ø)
unit_tests 23.99% <ø> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 90 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocket8888 ocket8888 added Traffic Monitor related to Traffic Monitor low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution labels Apr 5, 2023
@zrhoffman zrhoffman merged commit b616c06 into apache:master Apr 7, 2023
zrhoffman added a commit to zrhoffman/trafficcontrol that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Monitor related to Traffic Monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants