-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t3c add go_direct as a command line arg #7516
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7516 +/- ##
============================================
+ Coverage 27.74% 27.75% +0.01%
Complexity 98 98
============================================
Files 686 686
Lines 78128 78203 +75
Branches 90 90
============================================
+ Hits 21675 21705 +30
- Misses 54396 54436 +40
- Partials 2057 2062 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes tested and some suggested changes already made.
I re-ran the t3c tests; they're failing consistently |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
features manually tested.
This adds the ability to control the go_direct directive in parent.config using a command line argument. By default if no argument is supplied go_direct will be set to true on all delivery services and all tiers. If --set-go-direct=false all will be set to false. this is also overridable on a per tier and per delivery service basis using a delivery service profile and a parameter for go_direct_[edge|mid] and also go_direct_[first|inner|last]
Which Traffic Control components are affected by this PR?
t3c
, formerly ORT)What is the best way to verify this PR?
Run updated unit tests. also install t3c and run on a test cache with and with out arguments, and with or without override params.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist