Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t3c add go_direct as a command line arg #7516

Merged
merged 12 commits into from
Jun 7, 2023
Merged

Conversation

jpappa200
Copy link
Contributor

This adds the ability to control the go_direct directive in parent.config using a command line argument. By default if no argument is supplied go_direct will be set to true on all delivery services and all tiers. If --set-go-direct=false all will be set to false. this is also overridable on a per tier and per delivery service basis using a delivery service profile and a parameter for go_direct_[edge|mid] and also go_direct_[first|inner|last]


Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)

What is the best way to verify this PR?

Run updated unit tests. also install t3c and run on a test cache with and with out arguments, and with or without override params.

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@zrhoffman zrhoffman added new feature A new feature, capability or behavior cache-config Cache config generation labels May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #7516 (de903b9) into master (2e995e7) will increase coverage by 0.01%.
The diff coverage is 47.50%.

@@             Coverage Diff              @@
##             master    #7516      +/-   ##
============================================
+ Coverage     27.74%   27.75%   +0.01%     
  Complexity       98       98              
============================================
  Files           686      686              
  Lines         78128    78203      +75     
  Branches         90       90              
============================================
+ Hits          21675    21705      +30     
- Misses        54396    54436      +40     
- Partials       2057     2062       +5     
Flag Coverage Δ
golib_unit 48.59% <66.07%> (+0.03%) ⬆️
grove_unit 4.60% <ø> (ø)
t3c_unit 5.31% <4.16%> (-0.01%) ⬇️
traffic_monitor_unit 21.35% <ø> (ø)
traffic_ops_unit 23.42% <ø> (ø)
traffic_stats_unit 10.14% <ø> (ø)
unit_tests 24.42% <47.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cache-config/t3c-apply/config/config.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/torequest/cmd.go 0.00% <0.00%> (ø)
cache-config/t3c-generate/config/config.go 0.83% <0.00%> (-0.06%) ⬇️
cache-config/t3c-generate/cfgfile/wrappers.go 49.45% <50.00%> (+<0.01%) ⬆️
lib/go-atscfg/parentdotconfig.go 65.76% <64.15%> (-0.48%) ⬇️
lib/go-atscfg/parentabstraction.go 80.00% <100.00%> (ø)
lib/go-atscfg/strategiesdotconfig.go 91.86% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocket8888 ocket8888 added the low impact affects only a small portion of a CDN, and cannot itself break one label May 11, 2023
Copy link
Contributor

@traeak traeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes tested and some suggested changes already made.

@ocket8888
Copy link
Contributor

I re-ran the t3c tests; they're failing consistently

@jpappa200
Copy link
Contributor Author

t3c-git_test.go:70: getting git log: git error: in dir '/opt/trafficserver/etc/trafficserver' returned err exit status 128 msg 'fatal: detected dubious ownership in repository at '/opt/trafficserver/etc/trafficserver'
This is the error, I've rebased again. let's see if that helps.

Copy link
Contributor

@traeak traeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

features manually tested.

@zrhoffman zrhoffman merged commit f389b6c into apache:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cache-config Cache config generation low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants