-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To types rfc format #7575
To types rfc format #7575
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7575 +/- ##
============================================
+ Coverage 27.74% 29.27% +1.52%
Complexity 98 98
============================================
Files 686 739 +53
Lines 78128 81543 +3415
Branches 90 907 +817
============================================
+ Hits 21675 23869 +2194
- Misses 54396 55634 +1238
+ Partials 2057 2040 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 122 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are also missing a changelog entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested CRUD functionality locally and all works correctly, including RFC3339 timestamp.
Need to fix changelog and then we are good to merge. |
Closes: #7496
Related: #5911
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make Api calls to types 5.0
Types to Use RFC3339 Format
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist