Added api contract profile parameters test case #7604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholguin
requested changes
Jun 29, 2023
traffic_ops/testing/api_contract/v4/data/response_template.json
Outdated
Show resolved
Hide resolved
traffic_ops/testing/api_contract/v4/data/response_template.json
Outdated
Show resolved
Hide resolved
traffic_ops/testing/api_contract/v4/data/response_template.json
Outdated
Show resolved
Hide resolved
ericholguin
added
Traffic Ops
| logger.info("Deleting Profile Parameters data... %s", msg) | ||
| if msg is None: | ||
| logger.error("Profile Parameter returned by Traffic Ops is missing a 'profile_id' property") | ||
| pytest.fail("Response from delete request is empty, Failing test_case") |
There was a problem hiding this comment.
Indentation looks off after If loop in 1680 and 1681.
There was a problem hiding this comment.
Ok, I think it should be good now.
ericholguin
approved these changes
Jul 26, 2023
jagan-parthiban
pushed a commit
to jagan-parthiban/trafficcontrol
that referenced
this pull request
Jul 27, 2023
* added profile parameters test case * Refactored coordinates to match updated merge in conftest.py * Added get request for profile and parameters in conftest.py * Update request_template.json for profileId and parameterId * Added lastUpdated to response_template.json * Fixed assertion test_profile_parameters.py * Fixed indentation on line 1685 conftest.py * removed unnecessary profile_id var conftest.py * removed unnecessary declaration for parameter_Id conftest.py * fixed indentation conftest.py * Fixing inconsistent tabbing indentation conftest.py --------- Co-authored-by: yblanc545 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Api contract test case for profile parameters endpoint
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Step 1 : Follow steps from README file(traffic_ops/testing/api_contract) to run api-contract-tests.
Step 2 : To execute servers API Contract Testcase , navigate to traffic_ops/testing/api_contract/v4
pytest --to-user Username --to-password Password --to-url URL --config Config Path --request-template Request template --response-template Response template
Note: Config, Request template and response template paths are optional.
PR submission checklist