Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scope Parameter to Oauth Login #7609

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

dsouza93
Copy link
Contributor

The current implementation of the OAuth login is missing the scope query parameter. In order for Oauth to work properly we must add the scope.
https://oauth.net/2/scope/


Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

You could stand up a TP/TO and SSO service. Try logging in with SSO. Currently SSO providers were throwing an error saying something along the lines of "scope not provided". With this addition, the error should no longer exist and the SSO provider should provide TP with a code.

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

This is a small bug fix without tests
This PR should not change any functionality. The usage should be entirely the same. No documentation necessary.

@ericholguin ericholguin added Traffic Portal v1 related to Traffic Portal version 1 improvement The functionality exists but it could be improved in some way. authentication Relating to login, registration, passwords, tokens, etc. javascript Pull requests that update JavaScript or JavaScript-related code labels Jul 3, 2023
@ocket8888
Copy link
Contributor

TP test failure is related to driver version mismatch; not this PR

@dsouza93
Copy link
Contributor Author

dsouza93 commented Jul 5, 2023

@ocket8888 - Is there a way to resolve this or get the tests to run again? Do they need to pass to get this merged in?

@ocket8888
Copy link
Contributor

No, they're just gonna keep failing for no good reason

Copy link
Contributor

@kdamichie kdamichie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamped approved

@zrhoffman zrhoffman merged commit 79219bf into apache:master Jul 5, 2023
@dsouza93 dsouza93 deleted the oauth_source_param branch July 17, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Relating to login, registration, passwords, tokens, etc. improvement The functionality exists but it could be improved in some way. javascript Pull requests that update JavaScript or JavaScript-related code Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants