Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly require Java timezone data dependency #7675

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

zrhoffman
Copy link
Member

This PR fixes an error encountered in java-11-openjdk-11.0.20.0.8-2 on Rocky Linux, where it no longer has java-tzdata as a dependency, yet it installs a symlink to the tzdb.dat file that would be installed in that dependency. To reproduce:

$ docker run --rm rockylinux:8 bash -c 'dnf -y install java-11-openjdk-headless && realpath /usr/lib/jvm/java-11-openjdk-*/lib/tzdb.dat'
[...]
realpath: /usr/lib/jvm/java-11-openjdk-11.0.20.0.8-2.el8.x86_64/lib/tzdb.dat: No such file or directory

The fix is to require that dependency in the Traffic Router maven RPM configuration.


Which Traffic Control components are affected by this PR?

  • Traffic Router
  • Automation - Traffic Router builder image

What is the best way to verify this PR?

Try to build Traffic Router, verify you don't get an error. Alternatively, just check the result of the CI, which covers this change.

docker pull rockylinux:8
./pkg -v -b traffic_router_build

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@zrhoffman zrhoffman added Traffic Router related to Traffic Router regression bug a bug in existing functionality introduced by a new version dependencies Pull requests that update a dependency file labels Jul 26, 2023
@zrhoffman zrhoffman changed the title Require tzdata java Explicitly require Java timezone data dependency Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #7675 (ddd6491) into master (75ec56f) will increase coverage by 0.04%.
Report is 26 commits behind head on master.
The diff coverage is 84.61%.

@@             Coverage Diff              @@
##             master    #7675      +/-   ##
============================================
+ Coverage     65.05%   65.10%   +0.04%     
  Complexity       98       98              
============================================
  Files           314      314              
  Lines         12365    12359       -6     
  Branches        907      905       -2     
============================================
+ Hits           8044     8046       +2     
+ Misses         3968     3961       -7     
+ Partials        353      352       -1     
Flag Coverage Δ
traffic_router_unit 29.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
traffic_ops/v5-client/session.go 72.22% <50.00%> (-2.78%) ⬇️
...ffic-portal/src/app/api/testing/profile.service.ts 47.88% <66.66%> (+3.73%) ⬆️
...ntal/traffic-portal/src/app/api/profile.service.ts 93.75% <100.00%> (+1.59%) ⬆️
.../profiles/profile-table/profile-table.component.ts 69.23% <100.00%> (+5.59%) ⬆️
...raffic-portal/src/app/shared/file-utils.service.ts 94.11% <100.00%> (ø)
traffic_ops/v5-client/division.go 100.00% <100.00%> (ø)
traffic_ops/v5-client/federation_resolver.go 100.00% <100.00%> (ø)
traffic_ops/v5-client/phys_location.go 76.66% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jpappa200 jpappa200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

@zrhoffman zrhoffman merged commit 55d8070 into apache:master Jul 26, 2023
18 checks passed
jagan-parthiban pushed a commit to jagan-parthiban/trafficcontrol that referenced this pull request Jul 27, 2023
@zrhoffman zrhoffman deleted the require-tzdata-java branch July 31, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file regression bug a bug in existing functionality introduced by a new version Traffic Router related to Traffic Router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants