Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 logs should return rfc3339 time format #7690

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

srijeet0406
Copy link
Contributor

@srijeet0406 srijeet0406 commented Aug 2, 2023

This PR is not related to any issue. It fixes the timestamp for the logs api in version 5.0.


Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Make sure all the tests pass.
Hit the logs api on version 5.0 and make sure that the timestamps being returned are in rfc3339 format.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #7690 (0789a5f) into master (2233d22) will increase coverage by 2.57%.
Report is 15 commits behind head on master.
The diff coverage is 6.06%.

@@             Coverage Diff              @@
##             master    #7690      +/-   ##
============================================
+ Coverage     27.20%   29.78%   +2.57%     
  Complexity       98       98              
============================================
  Files           686      802     +116     
  Lines         79755    85784    +6029     
  Branches         90      952     +862     
============================================
+ Hits          21701    25552    +3851     
- Misses        55984    58094    +2110     
- Partials       2070     2138      +68     
Flag Coverage Δ
golib_unit 48.05% <0.00%> (-0.22%) ⬇️
grove_unit 4.60% <ø> (ø)
t3c_unit 4.95% <ø> (ø)
traffic_monitor_unit 21.30% <ø> (ø)
traffic_ops_integration 69.39% <100.00%> (ø)
traffic_ops_unit 22.28% <0.00%> (-0.41%) ⬇️
traffic_portal_v2 73.71% <ø> (?)
traffic_stats_unit 10.14% <ø> (ø)
unit_tests 26.94% <0.00%> (+3.04%) ⬆️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/go-tc/log.go 0.00% <0.00%> (ø)
traffic_ops/traffic_ops_golang/logs/log.go 0.00% <0.00%> (ø)
traffic_ops/v5-client/log.go 100.00% <100.00%> (ø)

... and 122 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@srijeet0406 srijeet0406 added new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops labels Aug 2, 2023
@ocket8888 ocket8888 added low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution and removed new feature A new feature, capability or behavior labels Aug 2, 2023
Copy link
Contributor

@kdamichie kdamichie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Approved

@zrhoffman zrhoffman merged commit 65f9941 into apache:master Aug 4, 2023
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants