-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add access control to varnish #7700
Add access control to varnish #7700
Conversation
marked as draft until #7669 is merged |
3f64677
to
0db717e
Compare
Codecov Report
@@ Coverage Diff @@
## master #7700 +/- ##
============================================
+ Coverage 26.88% 29.38% +2.49%
Complexity 98 98
============================================
Files 691 594 -97
Lines 81154 74530 -6624
Branches 90 90
============================================
+ Hits 21817 21897 +80
+ Misses 57261 50550 -6711
- Partials 2076 2083 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 106 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Add access control to Varnish server with the same rules as TS.
Which Traffic Control components are affected by this PR?
t3c
, formerly ORT)What is the best way to verify this PR?
following the same steps in #7669
-X "PURGE"
to curl command and it should return not allowed.mid-01.infra.ciab.test
. it will return not allowed too./opt/cache/etc/varnish/default.vcl
PR submission checklist
Fixes: #7714