Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RFC 3339 for lastUpdated timestamp in /statuses #7707

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

zrhoffman
Copy link
Member

This PR resolves #7706 by using the timestamp format specified in RFC 3339 for the lastUpdated field of the /api/5.0/statuses endpoint.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run the statuses API tests

PR submission checklist

@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution improvement The functionality exists but it could be improved in some way. labels Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #7707 (5e30a16) into master (849d166) will decrease coverage by 0.93%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #7707      +/-   ##
============================================
- Coverage     29.78%   28.85%   -0.93%     
  Complexity       98       98              
============================================
  Files           802      745      -57     
  Lines         85789    84214    -1575     
  Branches        952      952              
============================================
- Hits          25550    24302    -1248     
+ Misses        58099    57852     -247     
+ Partials       2140     2060      -80     
Flag Coverage Δ
traffic_ops_integration 65.66% <100.00%> (-3.74%) ⬇️
v3 57.79% <ø> (ø)
v4 ?
v5 78.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/go-tc/statuses.go 0.00% <ø> (ø)
traffic_ops/traffic_ops_golang/routing/routes.go 95.52% <ø> (-0.02%) ⬇️
traffic_ops/traffic_ops_golang/status/statuses.go 24.75% <ø> (ø)
traffic_ops/v5-client/status.go 100.00% <100.00%> (ø)

... and 57 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Code looks good and the v5 endpoint is responding properly with the new format.

@shamrickus shamrickus merged commit 48ec14e into apache:master Aug 11, 2023
43 of 44 checks passed
cybertunnel pushed a commit to cybertunnel/trafficcontrol that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/statuses in TO API uses non-RFC3339 date/time strings
2 participants