Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add automatic self-healing when using slice plugin to t3c #7719

Merged
merged 22 commits into from
Sep 27, 2023

Conversation

jpappa200
Copy link
Contributor

When using the slice plugin you have to add the --consider-ims parameter to the remap line in remap.config. This change will make it automatically add the parameter without using a delivery service parameter.


Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)

What is the best way to verify this PR?

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #7719 (c9b045c) into master (5c1d852) will increase coverage by 9.20%.
Report is 1 commits behind head on master.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##             master    #7719      +/-   ##
============================================
+ Coverage     28.93%   38.13%   +9.20%     
  Complexity       98       98              
============================================
  Files           602      428     -174     
  Lines         77379    34301   -43078     
  Branches         90       90              
============================================
- Hits          22392    13082    -9310     
+ Misses        52890    20036   -32854     
+ Partials       2097     1183     -914     
Flag Coverage Δ
golib_unit 53.85% <90.00%> (+0.01%) ⬆️
grove_unit 12.02% <ø> (ø)
t3c_unit 5.91% <ø> (ø)
traffic_monitor_unit 26.44% <ø> (ø)
traffic_ops_unit ?
traffic_stats_unit 10.78% <ø> (ø)
unit_tests 32.31% <90.00%> (+6.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/go-atscfg/remapdotconfig.go 77.62% <90.00%> (+<0.01%) ⬆️

... and 174 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericholguin ericholguin added new feature A new feature, capability or behavior medium impact impacts a significant portion of a CDN, or has the potential to do so cache-config Cache config generation labels Aug 16, 2023
@ocket8888 ocket8888 changed the title t3c to add self-healing automatically when using slice plugin add automatic self-healing when using slice plugin to t3c Aug 24, 2023
@jpappa200 jpappa200 force-pushed the t3c-slice-update branch 3 times, most recently from cbbedf6 to 48758de Compare September 21, 2023 17:13
Copy link
Contributor

@traeak traeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with requested changes these look good now.

lib/go-atscfg/remapdotconfig_test.go Outdated Show resolved Hide resolved
@zrhoffman zrhoffman merged commit 806b0d0 into apache:master Sep 27, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cache-config Cache config generation medium impact impacts a significant portion of a CDN, or has the potential to do so new feature A new feature, capability or behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants