Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplying absolute path for cert files in tests #7742

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

srijeet0406
Copy link
Contributor

This PR is not related to any issue. It makes sure that we are supplying absolute paths to the certs in our api tests.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Create client certs
Make sure the tests pass.
Manual testing:
Follow the steps in #7392

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #7742 (a59fed8) into master (a0f6b1f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7742   +/-   ##
=========================================
  Coverage     32.32%   32.32%           
  Complexity       98       98           
=========================================
  Files           710      710           
  Lines         79815    79815           
  Branches        965      965           
=========================================
  Hits          25798    25798           
  Misses        51870    51870           
  Partials       2147     2147           
Flag Coverage Δ
traffic_ops_integration 69.39% <ø> (ø)
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add labels to #7742.

@zrhoffman zrhoffman merged commit 4babb39 into apache:master Aug 23, 2023
10 checks passed
@srijeet0406 srijeet0406 added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one tests related to tests and/or testing infrastructure labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low impact affects only a small portion of a CDN, and cannot itself break one tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants