Traffic Router: Set "minimum" for SOA records to a custom value defined by a parameter #7808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srijeet0406
changed the title
srijeet0406
added
new feature
Codecov Report
@@ Coverage Diff @@
## master #7808 +/- ##
=========================================
Coverage 31.83% 31.83%
Complexity 98 98
=========================================
Files 717 717
Lines 82720 82720
Branches 965 965
=========================================
Hits 26338 26338
Misses 54217 54217
Partials 2165 2165
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zrhoffman
requested changes
Sep 25, 2023
...outer/core/src/main/java/org/apache/traffic_control/traffic_router/core/dns/ZoneManager.java
Outdated
Show resolved
Hide resolved
...outer/core/src/main/java/org/apache/traffic_control/traffic_router/core/dns/ZoneManager.java
Outdated
Show resolved
Hide resolved
...outer/core/src/main/java/org/apache/traffic_control/traffic_router/core/dns/ZoneManager.java
Show resolved
Hide resolved
jpappa200
pushed a commit
to jpappa200/trafficcontrol
that referenced
this pull request
Sep 27, 2023
…ed by a parameter (apache#7808) * initial commit * set param to dns neg ttl * adding changelog * change param name * fix tests * modify changelog * fix pmd * code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issue. It sets the SOA minimum to a custom value, when Traffic Router populates the auto-zones files.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run your local TR
Make DNS queries for valid and invalid FQDNs and ensure that the "minimum" returned in the SOA records is the custom value that you set the "dns.negative.caching.ttl" parameter in CRConfig.json to.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist