Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed topology link under ds/servers table page. #7918

Merged

Conversation

rimashah25
Copy link
Contributor

Closes: #6270


Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Go to a Delivery Service(DS). Under more, click on Manager Servers. If the DS has topology assigned it will show in the title else it will not.

When a topology is assigned to a DS:
image

When there is no topology assigned to a DS:
image

If this is a bugfix, which Traffic Control versions contained the bug?

master

PR submission checklist

@rimashah25 rimashah25 marked this pull request as ready for review January 18, 2024 19:12
@rimashah25 rimashah25 added Traffic Portal v1 related to Traffic Portal version 1 regression bug a bug in existing functionality introduced by a new version labels Jan 18, 2024
Copy link
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchell852 mitchell852 merged commit 14d45ac into apache:master Jan 19, 2024
33 checks passed
@rimashah25 rimashah25 deleted the bugfix/ds-server-page-topology-link branch January 19, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression bug a bug in existing functionality introduced by a new version Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect link to null topology when delivery service does not utilize a topology
2 participants