Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store Apache Traffic Server and grove logs in /var/log/trafficserver #7980

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Store Apache Traffic Server and grove logs in /var/log/trafficserver #7980

merged 4 commits into from
Aug 16, 2024

Conversation

zrhoffman
Copy link
Member

This PR changes configuration to log Apache Traffic Server and Grove to /var/log/trafficserver instead of /opt/trafficserver/var/log/trafficserver so that the logs are on a different partition than the application itself.

Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT) - tests
  • Apache Traffic Server
  • Grove
  • Transitive Source Build targeting ATS
  • Automation - Ansible roles configuration for grove log directory

What is the best way to verify this PR?

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@zrhoffman zrhoffman added Traffic Server related to Apache Traffic Server improvement The functionality exists but it could be improved in some way. logging related to logging infrastructure grove related to the "grove" HTTP caching server implementation labels Apr 3, 2024
@ntheanh201
Copy link
Contributor

Should we also upgrade ATS's version? #7958

@zrhoffman
Copy link
Member Author

Should we also upgrade ATS's version? #7958

Definitely. I think the only reason that #7958 is not approved already is the realpath on macOS issue that the reviewer encounted. Hopefully #7981 will unblock that.

@ntheanh201
Copy link
Contributor

ntheanh201 commented Apr 7, 2024 •
edited
Loading

I cannot test DS with your new ATS Edge, when I try to start ATS service, it shows that you still have to change to /var/log/trafficserver with traffic.out

P/s: I created a PR to your repo to fix this issue, can you take a look? @zrhoffman
image

@zrhoffman
Copy link
Member Author

I cannot test DS with your new ATS Edge, when I try to start ATS service, it shows that you still have to change to /var/log/trafficserver with traffic.out

P/s: I created a PR to your repo to fix this issue, can you take a look? @zrhoffman image

Thanks @ntheanh201! zrhoffman#122 is merged.

@ntheanh201
Copy link
Contributor

Is there anything else in this PR that you need to check? the CI failed? @zrhoffman

@zrhoffman zrhoffman force-pushed the ats-var/log branch 3 times, most recently from 8219f09 to 123445f Compare July 22, 2024 18:18
@zrhoffman
Copy link
Member Author

Rebased to fix merge conflicts

@zrhoffman
Copy link
Member Author

Is there anything else in this PR that you need to check? the CI failed? @zrhoffman

If CI passes and the logs show up in /var/log/trafficserver, then it should be safe to merge :)

@ntheanh201
Copy link
Contributor

Is there anything else in this PR that you need to check? the CI failed? @zrhoffman

If CI passes and the logs show up in /var/log/trafficserver, then it should be safe to merge :)

Looks like it's safe now 😁

@ntheanh201
Copy link
Contributor

anything to check? @zrhoffman

zrhoffman and others added 4 commits August 15, 2024 21:49
@zrhoffman
Store Apache Traffic Server logs in /var/log/trafficserver
9738614
@zrhoffman
Store Grove logs in /var/log/trafficserver
438cc70
@ntheanh201
chore: change ATS traffic.out folder to /var/log/trafficserver (#122)
a0cc302 
* chore: change ATS traffic.out folder to /var/log/trafficserver

* chore: add license
@ntheanh201 @asf-ci-trafficcontrol @zrhoffman
fix ciab-build (#125)
c9b74b5 
* fix ciab-build

* fix yumserver Dockerfile

* Update Go version to 1.22.5 (apache#8034)

* Update Go version to 1.22.5

* Update some images to Rocky Linux 8

---------

Co-authored-by: asf-ci-trafficcontrol <[email protected]>
Co-authored-by: Zach Hoffman <[email protected]>

---------

Co-authored-by: asf-ci-trafficcontrol <[email protected]>
Co-authored-by: Zach Hoffman <[email protected]>
@zrhoffman
Copy link
Member Author

That covers it, thanks @ntheanh201!

@zrhoffman zrhoffman merged commit 698d7f5 into apache:master Aug 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
grove related to the "grove" HTTP caching server implementation improvement The functionality exists but it could be improved in some way. logging related to logging infrastructure Traffic Server related to Apache Traffic Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zrhoffman @ntheanh201