Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TPv2] Update page titles and url for create() call #7998

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

rimashah25
Copy link
Contributor

Closes: #7418


Which Traffic Control components are affected by this PR?

  • Traffic Portalv2

What is the best way to verify this PR?

  1. Create a new physical locations/capabilities/coordinates/divisiona/regions/asns/roles/uers/tenants/types/origins/parameters/profiles and it should update the title and route of the page.
  2. Update a physical locations/capabilities/coordinates/divisiona/regions/asns/roles/uers/tenants/types/origins/parameters/profiles etc and it should update the title and NOT the route of the page.

If this is a bugfix, which Traffic Control versions contained the bug?

master

PR submission checklist

… to fix title issue, replaced variable name, header with navSvc, added setTitles(), removed replaceState and updated route for delete and create functionality, fixed Unit Tests in origin, users, cache-groups, fixed tests - finally, added delete dialog to tenant, and fixed title for CDN
@rimashah25 rimashah25 marked this pull request as ready for review April 24, 2024 19:29
@zrhoffman zrhoffman merged commit e20656a into apache:master Apr 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TPv2] Changes to new and edit pages across code base to update title, url
2 participants