Changes for ATC. 8.0.2 release #8080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimashah25
changed the title
rimashah25
force-pushed
the
bugfix/reset-password_sql-injection
branch
from
7c4638a
to
555413e
Compare
rimashah25
force-pushed
the
bugfix/reset-password_sql-injection
branch
from
555413e
to
c2c8ad5
Compare
rimashah25
force-pushed
the
bugfix/reset-password_sql-injection
branch
from
3b77390
to
5d44c4b
Compare
* docker-compose -> docker compose
Excludes Dockerfile-tsb and the vendor directory.
sed -i 's/docker-compose /docker compose /g' $(git grep -l 'docker-compose ')
pattern="$(<<'PATTERN' cat
docker-compose\($\|['`"*,)]\)
PATTERN
)"
sed -i "s/${pattern}/docker compose\1/g" -- $(git grep -l "$pattern")
sed -i 's/"docker compose"/"docker", "compose"/g' $(git grep -Fl '"docker compose"')
* Remove version from compose files.
sed -i '/^version:/d' $(git grep -il '^version:' '*docker-compose*.y*ml')
* Include `--all` in docker-compose ps command.
This is necessary for the plugin version of docker compose to query
exited containers.
* Changelog entry
* Support docker compose fallback for older docker versions that do not
have the compose plugin
…pache#8081) Fixes message: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
rimashah25
force-pushed
the
bugfix/reset-password_sql-injection
branch
from
752a67c
to
0726b45
Compare
zrhoffman
requested changes
Sep 27, 2024
There was a problem hiding this comment.
-
The Traffic Ops and Traffic Vault Database Tests / tests (pull_request) GHA is failing. Update Postgres version to 13.16 #8079 fixes it
-
CDN-in-a-Box CI / traffic_portal_v2 (pull_request) fails:
Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
|
Also, TPv2 e2e tests fail because the Chromedriver dependency is out of date |
* Use :atc-postgres-version: role in documentation * Get postgres version from .env in Traffic Ops spec file * Get POSTGRES_VERSION from .env in Dockerfiles and docker-compose files * Update Postgres version to 13.16
* No substitution in the name * Download ATS from the Apache archive download.apache.org only contains currently-supported releases. * Use Alpine main repo version 3.16 for adding package libexecinfo-dev Alpine versions above 3.16 do not contain package libexecinfo-dev, which ATS needs. Alpine 3.19 still fails for unknown reasons, but Alpine 3.18 builds with this fix. * Set default for GITHUB_REPOSITORY * Update Apache Traffic Server to 9.2.4 (cherry picked from commit 14007e3)
Co-authored-by: asf-ci-trafficcontrol <[email protected]> (cherry picked from commit f647d58)
zrhoffman
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Close! Still need to update this reference to actions/cache@v2:
trafficcontrol/.github/workflows/ciab.yaml
Line 188 in 970c493
to get CDN-in-a-Box CI / traffic_portal_v2 (pull_request) to pass, and
update Chromedriver to get TPv2 e2e tests to pass.
Update chromedriver (cherry picked from commit 289c2c3)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0.x #8080 +/- ##
============================================
- Coverage 28.89% 27.11% -1.79%
Complexity 98 98
============================================
Files 850 736 -114
Lines 90980 87837 -3143
Branches 970 970
============================================
- Hits 26289 23816 -2473
+ Misses 62533 62024 -509
+ Partials 2158 1997 -161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rimashah25
force-pushed
the
bugfix/reset-password_sql-injection
branch
from
a28534f
to
cccf8d9
Compare
* Update Go version to 1.22.5 * Update some images to Rocky Linux 8 --------- Co-authored-by: asf-ci-trafficcontrol <[email protected]> Co-authored-by: Zach Hoffman <[email protected]> (cherry picked from commit 0b21b43)
zrhoffman
requested changes
Sep 27, 2024
Co-authored-by: asf-ci-trafficcontrol <[email protected]> (cherry picked from commit f647d58)
zrhoffman
approved these changes
Sep 27, 2024
zrhoffman
added a commit
that referenced
this pull request
Sep 27, 2024
This reverts commit bf8568c.
zrhoffman
added a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: 8056, 8071, and 8081
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bugfix, which Traffic Control versions contained the bug?
8.0.1
PR submission checklist