Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay] Bias missing in final layer of Mobilenet? #4670

Closed
gussmith23 opened this issue Jan 9, 2020 · 2 comments · Fixed by #4801
Closed

[Relay] Bias missing in final layer of Mobilenet? #4670

gussmith23 opened this issue Jan 9, 2020 · 2 comments · Fixed by #4801
Labels
status: help wanted

Comments

@gussmith23
Copy link
Contributor

https://github.com/apache/incubator-tvm/blob/3f43bee01ea50d21ef93f618be3540bcf5231cd7/python/tvm/relay/testing/mobilenet.py#L123

Should there be a bias added here? I'm not 100% sure on this.
@FrozenGene
Copy link
Member

Yes. I think we miss it.

@tqchen
Copy link
Member

tqchen commented Jan 15, 2020 •
edited
Loading

Yes, we should add it, a PR is more than welcomed

kshitij12345 added a commit to kshitij12345/incubator-tvm that referenced this issue Feb 2, 2020
@kshitij12345
fix apache#4670: add bias for fc layer
cacccee
@kshitij12345 kshitij12345 mentioned this issue Feb 2, 2020
Merged
tqchen pushed a commit that referenced this issue Feb 2, 2020
@kshitij12345
fix #4670: add bias for fc layer (#4801)
396095a
alexwong pushed a commit to alexwong/tvm that referenced this issue Feb 26, 2020
@kshitij12345 @alexwong
fix apache#4670: add bias for fc layer (apache#4801)
766cf08
alexwong pushed a commit to alexwong/tvm that referenced this issue Feb 28, 2020
@kshitij12345 @alexwong
fix apache#4670: add bias for fc layer (apache#4801)
66a9e9a
zhiics pushed a commit to neo-ai/tvm that referenced this issue Mar 2, 2020
@kshitij12345 @zhiics
fix apache#4670: add bias for fc layer (apache#4801)
1e262ff
@ZihengJiang ZihengJiang mentioned this issue Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #4670: add bias for fc layer kshitij12345/incubator-tvm
3 participants
@gussmith23 @tqchen @FrozenGene