Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dilation in x86 NCHWc depthwise conv #4962

Closed
masahi opened this issue Feb 28, 2020 · 1 comment
Closed

Support dilation in x86 NCHWc depthwise conv #4962

masahi opened this issue Feb 28, 2020 · 1 comment
Labels
status: help wanted

Comments

@masahi
Copy link
Member

masahi commented Feb 28, 2020 •
edited
Loading

Hi, I hit an unimplemented error using NCHWc depthwise convolution with dilation on x86.

https://github.com/apache/incubator-tvm/blob/9816efc2df63cf6a14a6de46dc2adfafde58acc1/topi/python/topi/x86/depthwise_conv2d.py#L128

Is there any difficulty in supporting dilation for NCHWc layout? Or is it just that nobody has got around implementing it? Dilation is important for image segmentation use cases.

@yzhliu @kevinthesun @anijain2305 @yidawang
@anijain2305
Copy link
Contributor

anijain2305 commented Feb 28, 2020 •
edited
Loading

I think it is just a missing feature.

wjliu1998 added a commit to wjliu1998/incubator-tvm that referenced this issue Aug 13, 2020
@wjliu1998
add dilation in x86 NCHWc depthwise conv support (apache#4962)
7c968ee
@wjliu1998 wjliu1998 mentioned this issue Aug 13, 2020
Merged
wjliu1998 added a commit to wjliu1998/incubator-tvm that referenced this issue Aug 13, 2020
@wjliu1998
add dilation in x86 NCHWc depthwise conv support (apache#4962)
2aaea26
wjliu1998 added a commit to wjliu1998/incubator-tvm that referenced this issue Aug 13, 2020
@wjliu1998
add dilation in x86 NCHWc depthwise conv support (apache#4962)
4abc65c
wjliu1998 added a commit to wjliu1998/incubator-tvm that referenced this issue Aug 14, 2020
@wjliu1998
add dilation in x86 NCHWc depthwise conv support (apache#4962)
93323cd
masahi pushed a commit that referenced this issue Aug 14, 2020
@wjliu1998
add dilation in x86 NCHWc depthwise conv support (#4962) (#6267)
ad0dbe0
@masahi masahi closed this as completed Aug 14, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this issue Aug 26, 2020
@wjliu1998
add dilation in x86 NCHWc depthwise conv support (apache#4962) (apach…
0d7843a 
…e#6267)
trevor-m pushed a commit to trevor-m/tvm that referenced this issue Aug 26, 2020
@wjliu1998
add dilation in x86 NCHWc depthwise conv support (apache#4962) (apach…
5aef471 
…e#6267)
trevor-m pushed a commit to trevor-m/tvm that referenced this issue Aug 26, 2020
@wjliu1998
add dilation in x86 NCHWc depthwise conv support (apache#4962) (apach…
42ee84b 
…e#6267)
trevor-m pushed a commit to trevor-m/tvm that referenced this issue Sep 2, 2020
@wjliu1998
add dilation in x86 NCHWc depthwise conv support (apache#4962) (apach…
38d250d 
…e#6267)
trevor-m pushed a commit to neo-ai/tvm that referenced this issue Sep 3, 2020
@wjliu1998 @trevor-m
add dilation in x86 NCHWc depthwise conv support (apache#4962) (apach…
7bd94d5 
…e#6267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@masahi @anijain2305