[ci] Check more events before pinging reviewers #10208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missing some events before (reviews without comments, PR updated from a draft -> ready for review) so these were being ignored when finding the latest event. This PR adds them and restructures the code a bit to make it more clear what is happening for each PR. This addresses some of the issues from apache#9983
driazati
requested review from
comaniac,
junrushao,
tqchen,
jroesch,
areusch,
yzhliu,
merrymercy and
icemelon
as code owners
areusch
reviewed
Feb 24, 2022
| f"Skipping #{pr['number']} since author {pr['author']['login']} is not in allowlist: {author_allowlist}" | ||
| ) | ||
| else: | ||
| print(f"Checking #{pr['number']}, {author_allowlist}") |
There was a problem hiding this comment.
Suggested change
| print(f"Checking #{pr['number']}, {author_allowlist}") | |
| print(f"Will check #{pr['number']}, {author_allowlist}") |
| print(f"Checking #{pr['number']}, {author_allowlist}") | ||
| prs_to_check.append(pr) | ||
|
|
||
| print(f"Summary: Checking {len(prs_to_check)} of {len(prs)} fetched") |
There was a problem hiding this comment.
Suggested change
| print(f"Summary: Checking {len(prs_to_check)} of {len(prs)} fetched") | |
| print(f"Summary: Need to check {len(prs_to_check)} of {len(prs)} fetched") |
|
we discussed offline and @driazati will address the remaining two comments in a follow-on to avoid blocking on CI test time. |
areusch
approved these changes
Feb 24, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* [ci] Check more events before pinging reviewers This was missing some events before (reviews without comments, PR updated from a draft -> ready for review) so these were being ignored when finding the latest event. This PR adds them and restructures the code a bit to make it more clear what is happening for each PR. This addresses some of the issues from apache#9983 * fix tests Co-authored-by: driazati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing some events before (reviews without comments, PR updated from a draft -> ready for review) so these were being ignored when finding the latest event. This PR adds them and restructures the code a bit to make it more clear what is happening for each PR. This addresses some of the issues from #9983
cc @areusch @hpanda-naut