[Relax] Remove name requirement from MergeCompositeFunctions #17212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
force-pushed
the
name_agnostic_merge_composite_functions
branch
from
98aa5c5
to
3e3985b
Compare
Prior to this commit, the `relax.transform.MergeCompositeFunctions`
required the module to contain a single Relax function named `"main"`.
Lack of this function would result in an error when
`mod->GetGlobalVar("main")` was called. Presence of any other Relax
function would cause an error, since they were not collected into the
`CompositeGroupsBuilder`.
This commit updates `MergeCompositeFunctions` to be indepedendent of
the names of the Relax functions in an IRModule. The transform now
updates all Relax functions that do not have the `attr::kPrimitive` or
`attr::kCodegen` attributes.
Closes apache#17210
Lunderberg
force-pushed
the
name_agnostic_merge_composite_functions
branch
from
061b266
to
4cb2d66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
relax.transform.MergeCompositeFunctionsrequired the module to contain a single Relax function named"main". Lack of this function would result in an error whenmod->GetGlobalVar("main")was called. Presence of any other Relax function would cause an error, since they were not collected into theCompositeGroupsBuilder.This commit updates
MergeCompositeFunctionsto be indepedendent of the names of the Relax functions in an IRModule. The transform now updates all Relax functions that do not have theattr::kPrimitiveorattr::kCodegenattributes.Closes #17210