Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELAY][OP] Split #1876

Merged
merged 11 commits into from
Oct 26, 2018
Merged

[RELAY][OP] Split #1876

merged 11 commits into from
Oct 26, 2018

Conversation

srkreddy1238
Copy link
Contributor

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other parts looks good

src/relay/op/tensor/transform.cc Outdated Show resolved Hide resolved
src/relay/op/tensor/transform.cc Outdated Show resolved Hide resolved
include/tvm/relay/attrs/transform.h Outdated Show resolved Hide resolved
@srkreddy1238
Copy link
Contributor Author

cc @junrushao1994 please have another look.

src/relay/op/tensor/transform.cc Outdated Show resolved Hide resolved
python/tvm/relay/op/transform.py Outdated Show resolved Hide resolved
@yzhliu yzhliu self-assigned this Oct 11, 2018
@yzhliu yzhliu added status: review in progress status: need update need update based on feedbacks labels Oct 11, 2018
python/tvm/relay/op/transform.py Outdated Show resolved Hide resolved
@tqchen
Copy link
Member

tqchen commented Oct 18, 2018

@junrushao1994 @srkreddy1238 can you followup again on this?

@srkreddy1238
Copy link
Contributor Author

@junrushao1994 & @tqchen have a look again.

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen
Copy link
Member

tqchen commented Oct 21, 2018

please rebase against master and note the changes in #1934

@srkreddy1238
Copy link
Contributor Author

@tqchen have a look

python/tvm/relay/op/transform.py Outdated Show resolved Hide resolved
src/relay/op/tensor/transform.cc Outdated Show resolved Hide resolved
src/relay/op/tensor/transform.cc Outdated Show resolved Hide resolved
src/relay/op/tensor/transform.cc Outdated Show resolved Hide resolved
Copy link
Member

@tqchen tqchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, thanks for being patient during the review process

tests/python/relay/test_op_level3.py Show resolved Hide resolved
@srkreddy1238
Copy link
Contributor Author

cc @tqchen pls have a look at the alpha equal for Div operator too.

@srkreddy1238
Copy link
Contributor Author

cc @tqchen

@tqchen tqchen merged commit e6e9b37 into apache:master Oct 26, 2018
@tqchen
Copy link
Member

tqchen commented Oct 26, 2018

Thanks @srkreddy1238 @junrushao1994 @yzhliu this is merged

eqy pushed a commit to eqy/tvm that referenced this pull request Oct 29, 2018
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
@srkreddy1238 srkreddy1238 deleted the ir-ops branch January 24, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants