-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELAY][OP] Split #1876
[RELAY][OP] Split #1876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other parts looks good
cc @junrushao1994 please have another look. |
44f33a7
to
96b6946
Compare
@junrushao1994 @srkreddy1238 can you followup again on this? |
@junrushao1994 & @tqchen have a look again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
please rebase against master and note the changes in #1934 |
@tqchen have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment, thanks for being patient during the review process
93ca456
to
3941864
Compare
cc @tqchen pls have a look at the alpha equal for |
3bbda52
to
e6e95da
Compare
cc @tqchen |
Thanks @srkreddy1238 @junrushao1994 @yzhliu this is merged |
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.