[Relay] fix error in ANF (too agressively inline atomic expression and create free variable). #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Feb 23, 2019
src/relay/pass/to_a_normal_form.cc
Outdated
| @@ -256,7 +256,8 @@ bool IsPrimitiveFunction(const Expr& e) { | |||
| return e.as<FunctionNode>() && Downcast<Function>(e)->IsPrimitive(); | |||
| } | |||
|
|
|||
| class Fill : ExprFunctor<Expr(const Expr&, const Var&)> { | |||
| using FlushTo = std::shared_ptr<Var>; // if it is defined, always flush current expr into it. | |||
There was a problem hiding this comment.
Please elaborate on why such data structure is introduced
|
@tqchen can you review? |
tqchen
approved these changes
Feb 26, 2019
|
Thanks @MarisaKirisame , this is now merged, please request more reviewers from the reviewer list next time :) |
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
…d create free variable). (apache#2665)
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
…d create free variable). (apache#2665)
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
…d create free variable). (apache#2665)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.