Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do type checking for the input and kernel in the qnn conv2d #3904

Merged
merged 4 commits into from
Sep 12, 2019
Merged

Do type checking for the input and kernel in the qnn conv2d #3904

merged 4 commits into from
Sep 12, 2019

Conversation

shoubhik
Copy link
Contributor

@shoubhik shoubhik commented Sep 5, 2019

The privous commit #3580 did not have the data type checks needed for qnn conv2d. Existing test cases are passing.

@shoubhik
Copy link
Contributor Author

shoubhik commented Sep 5, 2019

@anijain2305 can you verify the checks.

anijain2305
anijain2305 requested changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shoubhik for boosting the type checking. Indeed I missed the checks.
Left few comments.

Tagging others for merge assignment - @zhiics @vinx13

src/relay/qnn/op/convolution.cc Outdated Show resolved Hide resolved
src/relay/qnn/op/convolution.cc Outdated Show resolved Hide resolved
src/relay/qnn/op/convolution.cc Outdated Show resolved Hide resolved
@shoubhik
Copy link
Contributor Author

shoubhik commented Sep 6, 2019

@zhiics @vinx13 can you take a look at this PR.

zhiics
zhiics approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anijain2305
Copy link
Contributor

@vinx13 can this be merged?

@anijain2305
Copy link
Contributor

@zhiics can this be merged?

@zhiics zhiics merged commit 880c260 into apache:master Sep 12, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
@shoubhik @wweic
Do type checking for the input and kernel in the qnn conv2d (apache#3904
599ef84 
)

* [QNN] Convolution 2D Implementation.

Rebasing. Empty commit.

Clang-format styling.

* Reformatting code.

* Fixing lint issues.
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
@shoubhik @wweic
Do type checking for the input and kernel in the qnn conv2d (apache#3904
aec54ed 
)

* [QNN] Convolution 2D Implementation.

Rebasing. Empty commit.

Clang-format styling.

* Reformatting code.

* Fixing lint issues.
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 16, 2019
@shoubhik @wweic
Do type checking for the input and kernel in the qnn conv2d (apache#3904
99235fd 
)

* [QNN] Convolution 2D Implementation.

Rebasing. Empty commit.

Clang-format styling.

* Reformatting code.

* Fixing lint issues.
@tqchen tqchen mentioned this pull request Nov 8, 2019
Closed
@anijain2305 anijain2305 deleted the qnn_conv2d branch November 13, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiics zhiics zhiics approved these changes

@anijain2305 anijain2305 anijain2305 approved these changes

@kevinthesun kevinthesun kevinthesun approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shoubhik @anijain2305 @zhiics @kevinthesun