[REFACTOR] Polish runtime #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
force-pushed
the
object
branch
3 times, most recently
from
64c2483
to
a5107f9
Compare
ZihengJiang
approved these changes
Jan 16, 2020
- Remove operator bool from base object ref macro
- Raitionale: operator bool can be dangerous for sub-classes
that also overloads other operators(e.g. ==).
- If bool is still needed, use explicit operator bool.
- Use absolute include when necessary
- Move type related util to data_type
- Isolate stackvm code from compiler
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
- Remove operator bool from base object ref macro
- Raitionale: operator bool can be dangerous for sub-classes
that also overloads other operators(e.g. ==).
- If bool is still needed, use explicit operator bool.
- Use absolute include when necessary
- Move type related util to data_type
- Isolate stackvm code from compiler
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
- Remove operator bool from base object ref macro
- Raitionale: operator bool can be dangerous for sub-classes
that also overloads other operators(e.g. ==).
- If bool is still needed, use explicit operator bool.
- Use absolute include when necessary
- Move type related util to data_type
- Isolate stackvm code from compiler
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
- Remove operator bool from base object ref macro
- Raitionale: operator bool can be dangerous for sub-classes
that also overloads other operators(e.g. ==).
- If bool is still needed, use explicit operator bool.
- Use absolute include when necessary
- Move type related util to data_type
- Isolate stackvm code from compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that also overloads other operators(e.g. ==).
cc @icemelon9 @ZihengJiang