Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Separate ArgTypeCode from DLDataTypeCode #5730

Merged
merged 1 commit into from
Jun 4, 2020
Merged

[REFACTOR] Separate ArgTypeCode from DLDataTypeCode #5730

merged 1 commit into from
Jun 4, 2020

Commits on Jun 4, 2020

  1. [REFACTOR] Separate ArgTypeCode from DLDataTypeCode 

    We use a single enum(TypeCode) to represent ArgTypeCode and DLDataTypeCode.
However, as we start to expand more data types, it is clear that argument
type code(in the FFI convention) and data type code needs to evolve separately.
So that we can add first class for data types without having changing the FFI ABI.

This PR makes the distinction clear and refactored the code to separate the two.

- [PY] Separate ArgTypeCode from DataTypeCode
- [WEB] Separate ArgTypeCode from DataTypeCode
- [JAVA] Separate ArgTypeCode from DataTypeCode
    @tqchen
    tqchen committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    24fbcf4 View commit details
    Browse the repository at this point in the history