[BYOC][COREML] Handle one symbol for each runtime #5989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiics
reviewed
Jul 6, 2020
| stream->Write(symbol_); | ||
| stream->Write((uint64_t)[dirData length]); | ||
| stream->Write([dirData bytes], [dirData length]); | ||
| LOG(INFO) << "Save " << symbol_ << " (" << [dirData length] << " bytes)"; |
|
|
||
| // TODO: Support multiple outputs. | ||
| NDArray out = model.GetOutput(0); | ||
| NDArray out = model_->GetOutput(0); | ||
| if (args[args.size() - 1].type_code() == kTVMDLTensorHandle) { | ||
| DLTensor* arg = args[args.size() - 1]; | ||
| out.CopyTo(arg); |
There was a problem hiding this comment.
Are the ndarrays allocated by the host for both inputs and outputs? If so, I think we might be able to do zero copy (in a separate PR).
There was a problem hiding this comment.
Yes, will do it in the next PR :)
zhiics
approved these changes
Jul 14, 2020
|
Thanks @kazum |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jul 14, 2020
* [BYOC][COREML] Handle one symbol for each runtime * LOG -> DLOG
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 14, 2020
* [BYOC][COREML] Handle one symbol for each runtime * LOG -> DLOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's no longer necessary to handle multiple subgraphs in one runtime thanks to the change of #5770, which simplifies the CoreML runtime a bit.
@zhiics @mbaret @FrozenGene Please help this to review.