Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VTA][OpenCL] add device_annot support in graphpack #6125

Merged
merged 6 commits into from
Dec 11, 2020
Merged

[VTA][OpenCL] add device_annot support in graphpack #6125

merged 6 commits into from
Dec 11, 2020

Conversation

zhanghaohit
Copy link
Contributor

This is related to #5840 and split from PR #5842

This PR depends on #6124 to work.

The new API allows to tag ext_dev device type from annot_start_name and annot_end_name

@zhanghaohit zhanghaohit changed the title add device_annot support in graphpack [VTA][OpenCL] add device_annot support in graphpack Jul 23, 2020
@zhanghaohit zhanghaohit mentioned this pull request Jul 23, 2020
Closed
tmoreau89
tmoreau89 requested changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent accidental PR merged given that this depends on #6124, I'm setting it to "changes requested"

@tmoreau89 tmoreau89 mentioned this pull request Jul 24, 2020
Merged
@zhanghaohit
Copy link
Contributor Author

To prevent accidental PR merged given that this depends on #6124, I'm setting it to "changes requested"

@tmoreau89 Thanks for reviewing #6124. Shall we start review this PR?

@tmoreau89
Copy link
Contributor

@zhanghaohit thanks for the ping, @ZihengJiang can you help me review this PR?

tmoreau89
tmoreau89 reviewed Aug 26, 2020
View reviewed changes
python/tvm/relay/op/_tensor.py
# a fake on_device schedule.
# this will not be used in actual computation
# as on_device will be removed during DeviceAnnotation pass
register_injective_schedule("on_device")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhanghaohit what happens if we don't register this annotation op schedule?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will raise
AssertionError: on_device doesn't have FTVMStrategy registered
during build_module.cc::Optimize before we do the RunDeviceAnnotationPass.

@ZihengJiang
Copy link
Contributor

ZihengJiang commented Aug 27, 2020 •
edited
Loading

I am wondering whether VTA's graph annotation can be unified into the relay's heterogeneous execution feature: #4178

@zhanghaohit zhanghaohit reopened this Aug 28, 2020
@zhanghaohit
Copy link
Contributor Author

I am wondering whether VTA's graph annotation can be unified into the relay's heterogeneous execution feature: #4178

I think #4178 is for VM, while graph annotation is for graph runtime?

@tqchen tqchen changed the base branch from master to main October 11, 2020 18:28
@zhanghaohit
Copy link
Contributor Author

ping @ZihengJiang

@ZihengJiang
Copy link
Contributor

Please fix the CI issue @zhanghaohit

@zhanghaohit
Copy link
Contributor Author

Please fix the CI issue @zhanghaohit

Fixed. Thanks @ZihengJiang @tmoreau89 for the review.

@zhanghaohit
Copy link
Contributor Author

ping @tmoreau89

tmoreau89
tmoreau89 approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhanghaohit LGTM

@tmoreau89 tmoreau89 merged commit 1e6e202 into apache:main Dec 11, 2020
@zhanghaohit zhanghaohit deleted the feature/graphpack branch December 17, 2020 01:57
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
@zhanghaohit
[VTA][OpenCL] add device_annot support in graphpack (apache#6125)
acb7e3b 
* add device_annot support in graphpack

* on_device annotation

* lint

* typo

* fix lint

* fix lint
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
@zhanghaohit @trevor-m
[VTA][OpenCL] add device_annot support in graphpack (apache#6125)
86d32e5 
* add device_annot support in graphpack

* on_device annotation

* lint

* typo

* fix lint

* fix lint
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
@zhanghaohit @electriclilies
[VTA][OpenCL] add device_annot support in graphpack (apache#6125)
1ef8ba4 
* add device_annot support in graphpack

* on_device annotation

* lint

* typo

* fix lint

* fix lint
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZihengJiang ZihengJiang ZihengJiang approved these changes

@tmoreau89 tmoreau89 tmoreau89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhanghaohit @tmoreau89 @ZihengJiang