[BUG_FIX] Fix resize test

[electriclilies]

This PR fixes the bug in #6237. In resize, the method "nearest_neighbor" is not compatible with the coordinate_transform_mode "align_corners", and the method "bilinear" is not compatible with coordinate_transformation_modes other than "align_corners".

I also added checks to the topi resize method to prevent the user from passing incompatible method and coordinate_transformation_mode combinations into resize.

@mbrookhart @masahi please take a look!

[mbrookhart]

Add another test case? I'm wondering about the combinations of the various modes, the check is missing any reference to half_pixel and bicubic.

[mbrookhart]

test_dynamic_to_static_resize also needs to be updated, otherwise looks great

[masahi]

Frontend tests are failing really bad with this change. We need to fix hardcoded
https://github.com/apache/incubator-tvm/blob/0a4ee30da727ae1566a0541ba6ed726d48733cc7/python/tvm/relay/frontend/onnx.py#L935

There is also bilinear + align_corners=False combination in tflite test, which translates to bilinear + asymmetric in Relay:
https://github.com/apache/incubator-tvm/blob/77042327d944fbfa243f59740c087d433bc1569e/tests/python/frontend/tflite/test_forward.py#L1058

I don't know what TF does with bilinear + align_corners=False. Also not sure if bilinear + asymmetric in Relay is a valid combination. Maybe @jwfromm @srkreddy1238 have thought on this?

[electriclilies]

@masahi I changed the onnx frontend to set align_corners to False if the method is 'nearest_neighbor', otherwise set it to true. This got rid of the issue in the onnx importer.

TFLite is not passing one test, though, because it's trying to use the bilinear + asymmetric combination...

[electriclilies]

It looks like bilinear + asymmetric passes the resize test, but for some reason it is not tested in the topi test. I added it to the topi test and removed that check from the topi resize op.

[masahi]

Yes this change now looks good to me. After CI pass we can merge.

[electriclilies]

@masahi Thanks!

[masahi]

oh CI is failing because there is nearest + half_pixel combination in pytorch frontend ...

https://github.com/apache/incubator-tvm/blob/939a42b4e976a41e8513b720421d3c3678493715/python/tvm/relay/frontend/pytorch.py#L1542-L1545

@electriclilies can you fix the condition above to

        if method == "nearest_neighbor":
            coord_trans = "asymmetric"
        elif align_corners:
            coord_trans = "align_corners"
        else:
            coord_trans = "half_pixel"

Options in resize is a hairy issue, sorry to have you go through this.

[electriclilies]

@masahi Thanks! it looks like there is a similar condition in upsample3d, I also changed that for consistency. Let me know if you think that will cause a problem

[masahi]

Thanks @electriclilies @mbrookhart