Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOPI] deformable_conv2d in NHWC #6999

Merged
merged 6 commits into from
Dec 1, 2020
Merged

[TOPI] deformable_conv2d in NHWC #6999

merged 6 commits into from
Dec 1, 2020

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Nov 30, 2020

@vinx13 vinx13 force-pushed the feature/deformable_nhwc_compute branch from ea62a1c to 5029317 Compare November 30, 2020 10:13
@vinx13 vinx13 force-pushed the feature/deformable_nhwc_compute branch from 5029317 to ade70a5 Compare November 30, 2020 11:19
comaniac
comaniac requested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a few comments. Also please fix the CI errors.

python/tvm/topi/generic/nn.py Outdated Show resolved Hide resolved
python/tvm/topi/testing/deformable_conv2d_python.py Outdated Show resolved Hide resolved
tests/python/topi/python/test_topi_deformable_conv2d.py Show resolved Hide resolved
@comaniac comaniac self-assigned this Nov 30, 2020
@vinx13 vinx13 force-pushed the feature/deformable_nhwc_compute branch 2 times, most recently from 0ecda28 to 31f23e7 Compare November 30, 2020 20:37
@vinx13 vinx13 force-pushed the feature/deformable_nhwc_compute branch from 31f23e7 to 9d48e86 Compare November 30, 2020 20:43
comaniac
comaniac approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac comaniac merged commit 73a1a9a into apache:main Dec 1, 2020
@comaniac
Copy link
Contributor

comaniac commented Dec 1, 2020

Thanks @vinx13 @merrymercy

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
@vinx13 @comaniac
[TOPI] deformable_conv2d in NHWC (apache#6999)
03d2c2b 
* [TOPI] deformable_conv2d in NHWC

* Update python/tvm/topi/generic/nn.py

Co-authored-by: Cody Yu <[email protected]>

* Update python/tvm/topi/testing/deformable_conv2d_python.py

Co-authored-by: Cody Yu <[email protected]>

* style

* fix

* style

Co-authored-by: Cody Yu <[email protected]>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
@vinx13 @comaniac
[TOPI] deformable_conv2d in NHWC (apache#6999)
f3b7908 
* [TOPI] deformable_conv2d in NHWC

* Update python/tvm/topi/generic/nn.py

Co-authored-by: Cody Yu <[email protected]>

* Update python/tvm/topi/testing/deformable_conv2d_python.py

Co-authored-by: Cody Yu <[email protected]>

* style

* fix

* style

Co-authored-by: Cody Yu <[email protected]>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
@vinx13 @comaniac @trevor-m
[TOPI] deformable_conv2d in NHWC (apache#6999)
1260b2c 
* [TOPI] deformable_conv2d in NHWC

* Update python/tvm/topi/generic/nn.py

Co-authored-by: Cody Yu <[email protected]>

* Update python/tvm/topi/testing/deformable_conv2d_python.py

Co-authored-by: Cody Yu <[email protected]>

* style

* fix

* style

Co-authored-by: Cody Yu <[email protected]>
@comaniac comaniac mentioned this pull request Dec 10, 2020
Merged
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy merrymercy left review comments

@comaniac comaniac comaniac approved these changes

Assignees

@comaniac comaniac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinx13 @comaniac @merrymercy