Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PatternLang] Add Syntatic Sugar to the C++ pattern API and support DataType Attribute Matching #7120

Merged
merged 5 commits into from
Jan 5, 2021
Merged

[PatternLang] Add Syntatic Sugar to the C++ pattern API and support DataType Attribute Matching #7120

merged 5 commits into from
Jan 5, 2021

Conversation

mbrookhart
Copy link
Contributor

cc @icemelon9

icemelon
icemelon reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm.

include/tvm/relay/dataflow_pattern.h Outdated Show resolved Hide resolved
tests/cpp/dataflow_pattern_test.cc Show resolved Hide resolved
include/tvm/relay/dataflow_pattern.h Show resolved Hide resolved
icemelon
icemelon approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you rebase to master?

include/tvm/relay/dataflow_pattern.h Show resolved Hide resolved
@icemelon icemelon merged commit d3bb762 into apache:main Jan 5, 2021
@icemelon
Copy link
Member

icemelon commented Jan 5, 2021

Thanks @mbrookhart

tkonolige pushed a commit to tkonolige/incubator-tvm that referenced this pull request Jan 11, 2021
@tkonolige
[PatternLang] Add Syntatic Sugar to the C++ pattern API and support D…
b48af65 
…ataType Attribute Matching (apache#7120)

* Add Syntatic Sugar for C++ Pattern API, Support DataType Attribute match

* add missing tests

* fix lint

* fix license edit

* fix bad rebase
masahi pushed a commit to masahi/tvm that referenced this pull request Jan 14, 2021
@masahi
[PatternLang] Add Syntatic Sugar to the C++ pattern API and support D…
55702de 
…ataType Attribute Matching (apache#7120)

* Add Syntatic Sugar for C++ Pattern API, Support DataType Attribute match

* add missing tests

* fix lint

* fix license edit

* fix bad rebase
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
[PatternLang] Add Syntatic Sugar to the C++ pattern API and support D…
442cf0d 
…ataType Attribute Matching (apache#7120)

* Add Syntatic Sugar for C++ Pattern API, Support DataType Attribute match

* add missing tests

* fix lint

* fix license edit

* fix bad rebase
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
@trevor-m
[PatternLang] Add Syntatic Sugar to the C++ pattern API and support D…
9bd9247 
…ataType Attribute Matching (apache#7120)

* Add Syntatic Sugar for C++ Pattern API, Support DataType Attribute match

* add missing tests

* fix lint

* fix license edit

* fix bad rebase
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
@electriclilies
[PatternLang] Add Syntatic Sugar to the C++ pattern API and support D…
c142dd7 
…ataType Attribute Matching (apache#7120)

* Add Syntatic Sugar for C++ Pattern API, Support DataType Attribute match

* add missing tests

* fix lint

* fix license edit

* fix bad rebase
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemelon icemelon icemelon approved these changes

Assignees

@icemelon icemelon

Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbrookhart @icemelon