Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BYOC][ACL] Depthwise convolution support #7206

Merged
merged 3 commits into from
Jan 11, 2021
Merged

[BYOC][ACL] Depthwise convolution support #7206

merged 3 commits into from
Jan 11, 2021

Conversation

d-smirnov
Copy link
Contributor

Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM.

Also rework tests to remove non-deterministic trials.

  • ACL is Compute Library for the Arm Architecture
  • All credits to Luke Hutton @lhutton1

lhutton1
lhutton1 reviewed Jan 4, 2021
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll take a closer look tomorrow. also cc @comaniac, @giuseros

python/tvm/relay/op/contrib/arm_compute_lib.py Outdated Show resolved Hide resolved
python/tvm/relay/op/contrib/arm_compute_lib.py Outdated Show resolved Hide resolved
python/tvm/relay/op/contrib/arm_compute_lib.py Outdated Show resolved Hide resolved
src/relay/backend/contrib/arm_compute_lib/codegen.cc Show resolved Hide resolved
@ZihengJiang ZihengJiang added the status: need update need update based on feedbacks label Jan 6, 2021
@lhutton1 @d-smirnov
[BYOC][ACL] Depthwise convolution support
f02e26e 
Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM.

Also rework tests to remove non-deterministic trials.

*Compute Library for the Arm Architecture (ACL).
*All credits to Luke Hutton @lhutton1

Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857
lhutton1
lhutton1 reviewed Jan 8, 2021
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, just one small thing I missed previously, otherwise looks good!

src/runtime/contrib/arm_compute_lib/acl_runtime.cc Outdated Show resolved Hide resolved
src/runtime/contrib/arm_compute_lib/acl_runtime.cc Outdated Show resolved Hide resolved
lhutton1
lhutton1 approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

mbaret
mbaret approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM too.

@mbaret mbaret merged commit 77e4fd1 into apache:main Jan 11, 2021
@mbaret
Copy link
Contributor

mbaret commented Jan 11, 2021

Thanks @d-smirnov @lhutton1 ! This is now merged.

tkonolige pushed a commit to tkonolige/incubator-tvm that referenced this pull request Jan 11, 2021
@d-smirnov @lhutton1 @tkonolige
[BYOC][ACL] Depthwise convolution support (apache#7206)
f782c39 
* [BYOC][ACL] Depthwise convolution support

Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM.

Also rework tests to remove non-deterministic trials.

*Compute Library for the Arm Architecture (ACL).
*All credits to Luke Hutton @lhutton1

Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857

* linter

* CHECK -> ICHECK

Co-authored-by: Luke Hutton <[email protected]>
masahi pushed a commit to masahi/tvm that referenced this pull request Jan 14, 2021
@d-smirnov @lhutton1 @masahi
[BYOC][ACL] Depthwise convolution support (apache#7206)
41b4142 
* [BYOC][ACL] Depthwise convolution support

Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM.

Also rework tests to remove non-deterministic trials.

*Compute Library for the Arm Architecture (ACL).
*All credits to Luke Hutton @lhutton1

Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857

* linter

* CHECK -> ICHECK

Co-authored-by: Luke Hutton <[email protected]>
masahi pushed a commit to masahi/tvm that referenced this pull request Jan 18, 2021
@d-smirnov @lhutton1 @masahi
[BYOC][ACL] Depthwise convolution support (apache#7206)
5b2233e 
* [BYOC][ACL] Depthwise convolution support

Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM.

Also rework tests to remove non-deterministic trials.

*Compute Library for the Arm Architecture (ACL).
*All credits to Luke Hutton @lhutton1

Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857

* linter

* CHECK -> ICHECK

Co-authored-by: Luke Hutton <[email protected]>
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
@d-smirnov @lhutton1
[BYOC][ACL] Depthwise convolution support (apache#7206)
cc108ff 
* [BYOC][ACL] Depthwise convolution support

Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM.

Also rework tests to remove non-deterministic trials.

*Compute Library for the Arm Architecture (ACL).
*All credits to Luke Hutton @lhutton1

Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857

* linter

* CHECK -> ICHECK

Co-authored-by: Luke Hutton <[email protected]>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
@d-smirnov @lhutton1 @trevor-m
[BYOC][ACL] Depthwise convolution support (apache#7206)
6164980 
* [BYOC][ACL] Depthwise convolution support

Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM.

Also rework tests to remove non-deterministic trials.

*Compute Library for the Arm Architecture (ACL).
*All credits to Luke Hutton @lhutton1

Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857

* linter

* CHECK -> ICHECK

Co-authored-by: Luke Hutton <[email protected]>
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
@d-smirnov @lhutton1 @electriclilies
[BYOC][ACL] Depthwise convolution support (apache#7206)
3a77fb2 
* [BYOC][ACL] Depthwise convolution support

Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM.

Also rework tests to remove non-deterministic trials.

*Compute Library for the Arm Architecture (ACL).
*All credits to Luke Hutton @lhutton1

Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857

* linter

* CHECK -> ICHECK

Co-authored-by: Luke Hutton <[email protected]>
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhutton1 lhutton1 lhutton1 approved these changes

@mbaret mbaret mbaret approved these changes

Assignees
No one assigned
Labels
status: need update need update based on feedbacks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-smirnov @mbaret @lhutton1 @ZihengJiang