Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QNN][TFLite] TFLite rounding mode support #7456

Closed
wants to merge 1 commit into from

Conversation

FrozenGene
Copy link
Member

@FrozenGene FrozenGene commented Feb 14, 2021

Almost work is done by @Fwd-IV Thanks! I just port it from #4828.

Some other import changes should be noticed is in the rewrite_simplify.cc / canonical_simplify.cc. We introduce expression complexity to determine whether we should do these optimizations. After introducing tflite rounding, we will have complex expressions, like this:
image

If we don't disable this , we even can not compile whole mobilenet v2 quantized model successfully.

This is also initial support for TFLite bit extract comparison . After this work, our qnn mobilenetv1/v2/inception and so on models we could get bit extract compared with tflite. I also think we have more work to do for more models.

Co-author-by: @Fwd-IV

@anijain2305 @mbrookhart @giuseros

@FrozenGene FrozenGene force-pushed the tflite_rounding branch 13 times, most recently from 06c238d to 4112141 Compare February 17, 2021 09:59
@tqchen
Copy link
Member

tqchen commented Feb 17, 2021

Thanks @FrozenGene can you move the analysis change to a separate PR so we can review that part carefully

@FrozenGene
Copy link
Member Author

Thanks @FrozenGene can you move the analysis change to a separate PR so we can review that part carefully

have separated it and resolve your comment

@mbrookhart
Copy link
Contributor

@FrozenGene Any chance you can rebase and fix CI?

Thanks!

@jroesch
Copy link
Member

jroesch commented Jan 19, 2022

This PR appears to be out of date, please feel free to reopen it if this is not the case.

As part of the new year we are attempting to triage the project's open pull requests to ensure that code which
is ready for review and/or merging receives adequate attention.

Thanks again for your contribution, and feel free to reach out to discuss these changes.

@jroesch jroesch closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants