modified schedule_dataflow_rewrite.cc to fix Stale Tensor during Dataflow Rewrite #738 #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Jan 3, 2018
| Tensor sugar_tensor = tensor; | ||
| Stage s = operator[](tensor->op); | ||
| if (!(s->op.same_as(tensor->op))) | ||
| sugar_tensor = s->op.output(0); |
There was a problem hiding this comment.
Use the sugar tensor’s value index instead of 0 when pass to output
There was a problem hiding this comment.
it seems very strange to blocked at 'test_topi_reduce.test_reduce_map', the only different between "Always use new tensor in its stage when rewrite for cache read #748" is that , the using of sugar tensor is more rigorous, so my change seems be more similar to the origin code . But #748 has passed the test.
tqchen
approved these changes
Jan 3, 2018
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Jul 6, 2018
…flow Rewrite apache#738 (apache#747) * modified schedule_dataflow_rewrite.cc to fix losing tensor problem * modified schedule_dataflow_rewrite.cc for lint scan * modified schedule_dataflow_rewrite.cc for lint scan * using tensor's value_index to index output of stage op
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
…flow Rewrite apache#738 (apache#747) * modified schedule_dataflow_rewrite.cc to fix losing tensor problem * modified schedule_dataflow_rewrite.cc for lint scan * modified schedule_dataflow_rewrite.cc for lint scan * using tensor's value_index to index output of stage op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified cache_read function to solve the ploblem of Stale Tensor during Dataflow Rewrite #738, mapping the tensor to a new sugar_tensor when find the tensor->op is changed.