-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BYOC][TensorRT] Make TRT runtime robust to empty or weird subgraphs #7581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-m
changed the title
[TRT] Make TRT runtime robust to empty or weird subgraphs
[BYOC][TensorRT] Make TRT runtime robust to empty or weird subgraphs
Mar 3, 2021
Thanks for the fix. Is it possbile to add a test case? |
Thanks @comaniac just added one Test output before fix
With fix:
|
comaniac
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @trevor-m |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…pache#7581) * Prevent TRT runtime crash for duplicate inputs and outputs * Add empty subgraph unit test
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…pache#7581) * Prevent TRT runtime crash for duplicate inputs and outputs * Add empty subgraph unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TensorRT doesn't allow a graph to use the same nodes as both an input and output, nor does it allow an output to be marked as an output multiple times.
It seems there are still some corners cases where the partitioning can make these subgraphs which would cause TRT to crash at runtime during graph build. This PR will prevent the crash and allow the model to execute properly. I think it's good to have this in place in case there are more issues with partitioning we aren't aware of yet.
I will make a separate PR to fix the partitioning bug I have found.