Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TVMC] Refactoring to document the --target regex and simplify test cases #7654

Merged
merged 1 commit into from
Mar 15, 2021
Merged

[TVMC] Refactoring to document the --target regex and simplify test cases #7654

merged 1 commit into from
Mar 15, 2021

Conversation

leandron
Copy link
Contributor

Follow up on #7651.

  • Adds comments to document the regex being used to parse the --target=value string
  • Concatenate test cases without reducing the number of asserts or number of actual tests

cc @giuseros @comaniac

@leandron leandron mentioned this pull request Mar 12, 2021
Merged
@leandron
[TVMC] Refactoring to document the --target regex and simplify test c…
ffdf0fa 
…ases

 * Adds comments to document the regex being used to parse the
   --target=value string
 * Concatenate test cases without reducing the number of asserts
   or number of actual tests
@tqchen tqchen merged commit 10f5d17 into apache:main Mar 15, 2021
@leandron leandron deleted the follow_up_tvmc_regex branch March 15, 2021 15:54
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@leandron
[TVMC] Refactoring to document the --target regex and simplify test c…
762e0c3 
…ases (apache#7654)

* Adds comments to document the regex being used to parse the
   --target=value string
 * Concatenate test cases without reducing the number of asserts
   or number of actual tests
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
@leandron @trevor-m
[TVMC] Refactoring to document the --target regex and simplify test c…
3d27729 
…ases (apache#7654)

* Adds comments to document the regex being used to parse the
   --target=value string
 * Concatenate test cases without reducing the number of asserts
   or number of actual tests
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

@u99127 u99127 u99127 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leandron @comaniac @u99127 @tqchen