[Relay][Frontend][ONNX] Raise error when user provides an input not in the onnx graph. #7699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no in the graph.
|
Thanks @jwfromm @mbrookhart |
AndrewZhaoLuo
pushed a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Mar 22, 2021
* main: [AutoScheduler] Add function name in message (apache#7703) [Vulkan] Workaround for zero size allocation (apache#7691) Change behavior of onnx importer to throw when user provides an input no in the graph. (apache#7699) Free TensorRT engine and context (apache#7702) [TFLite] Cast operator adapted for MLIR-based convertor (apache#7639) [CPP_RPC] allow user supplied work dir (apache#7670) Default value for graph_runtime Init lookup_linked_param_func (apache#7676)
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
… no in the graph. (apache#7699)
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
… no in the graph. (apache#7699)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was recently some discussion about how the onnx importer should handle being passed a shape dict that contains inputs not found in the onnx graph. Currently, the importer will just ignore these inputs. However, this could lead to user confusion if they make a simple typo and are expecting different behavior than what they get. This PR adds checking for inputs in the shape dict that arent part of the graph and informs the user if it finds any. Overall, this should provide a more clear experience.
I added a test to confirm the behavior works as described and found that one of our onnx tests (test_pad) was actually providing gratuitous input information.