Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend][tflite] float16 quant support #7736

Merged
merged 9 commits into from
Apr 17, 2021
Merged

[frontend][tflite] float16 quant support #7736

merged 9 commits into from
Apr 17, 2021

Conversation

euntaik
Copy link
Contributor

@euntaik euntaik commented Mar 24, 2021

add float16 quant support for fc and transpose_conv

)
for fp16_quantized in [False, True]:
if quantized and fp16_quantized:
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we skipping the fp16_quantized test

Copy link
Contributor Author

@euntaik euntaik Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fp16 quantized path doesn't go through quantized path.
quantized=True and fp16_quantzied=True goes through same code as quantized=False and fp16_quantize=True. So I just wanted to reduce the test time here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove the skipping code?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Yes, please. Can you restructure the test such that there is no need of skipping code. One might be confused while reading the code otherwise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Yes, please. Can you restructure the test such that there is no need of skipping code. One might be confused while reading the code otherwise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed your request.

@anijain2305
Copy link
Contributor

@euntaik What are the input and output dtypes for the float16 quantized graph? I do not see any cast operations in your PR. Is it possible to paste the TFLite float16 quantized graph here?

@euntaik
Copy link
Contributor Author

euntaik commented Apr 13, 2021

@euntaik What are the input and output dtypes for the float16 quantized graph? I do not see any cast operations in your PR. Is it possible to paste the TFLite float16 quantized graph here?

Cast(float16 to float32) is already done in the Dequantize node and the resulting expression is passed to the FullyConnected op as weight and bias.

Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anijain2305 anijain2305 merged commit 9a72ba3 into apache:main Apr 17, 2021
@anijain2305
Copy link
Contributor

Thanks @euntaik This is merged!

mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Apr 22, 2021
* [frontend][tflite] float16 quant support

* remove skip conditions in tests
@euntaik euntaik deleted the fix-tflite-float16 branch April 29, 2021 02:44
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
* [frontend][tflite] float16 quant support

* remove skip conditions in tests
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
* [frontend][tflite] float16 quant support

* remove skip conditions in tests
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
* [frontend][tflite] float16 quant support

* remove skip conditions in tests
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
* [frontend][tflite] float16 quant support

* remove skip conditions in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants