[microTVM] Zephyr: RISCV support for Zephyr QEMU RISCV-32/64 #7804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @areusch |
areusch
requested changes
Apr 7, 2021
There was a problem hiding this comment.
great work @mehrdadh ! just a couple small things to address.
apps/microtvm/zephyr/demo_runtime/qemu-hack/qemu-system-riscv64
Outdated
Show resolved
Hide resolved
|
BTW @mehrdadh here are some git tips that might be useful(try to rebase to bring the code back instead of merge) https://tvm.apache.org/docs/contribute/git_howto.html |
|
@tqchen Thanks for the tips! I will follow the guideline. |
|
@tqchen, this method unfortunately makes the review much harder because GH loses the old commits after force-push. If you're trying to decide whether an open comment has been addressed, it's really helpful to be able to be able to see the context which generated that comment and a diff. I think the strategy adopted by me (and a few others) has been to rebase and force-push until a comment is placed on the PR, then do merges. If we want to consider improving the situation, I think we unfortunately may have to look into a different code review tool e.g. Gerrit (unless I misunderstand repository config settings on GH). |
areusch
reviewed
Apr 8, 2021
| @@ -59,7 +66,7 @@ def _make_sess_from_op(model, zephyr_board, west_cmd, op_name, sched, arg_bufs): | |||
|
|
|||
|
|
|||
| def _make_session(model, target, zephyr_board, west_cmd, mod): | |||
| test_name = f"{os.path.splitext(os.path.abspath(__file__))[0]}_{model}" | |||
| test_name = f"{os.path.splitext(os.path.abspath(__file__))[0]}_{zephyr_board}" | |||
There was a problem hiding this comment.
why this change? seems like we should put both in the path, if anything
There was a problem hiding this comment.
@areusch so we distinguish the test based on the zephyr_board. For ex. qemu_x86, qemu_riscv32 and qemu_riscv64 all use the same model which is host, but they have different zephyr_board. zephyr_board will always be unique.
There was a problem hiding this comment.
oh sorry, I was misreading. this looks good
areusch
approved these changes
Apr 8, 2021
| @@ -59,7 +66,7 @@ def _make_sess_from_op(model, zephyr_board, west_cmd, op_name, sched, arg_bufs): | |||
|
|
|||
|
|
|||
| def _make_session(model, target, zephyr_board, west_cmd, mod): | |||
| test_name = f"{os.path.splitext(os.path.abspath(__file__))[0]}_{model}" | |||
| test_name = f"{os.path.splitext(os.path.abspath(__file__))[0]}_{zephyr_board}" | |||
There was a problem hiding this comment.
oh sorry, I was misreading. this looks good
tmoreau89
pushed a commit
to tmoreau89/tvm
that referenced
this pull request
Apr 11, 2021
…7804) * working on qemu * debugging * riscv hacks * config added * change target platforms * fix merge * debugging issue with zephyr 2.5 * cleanup * working on qemu * debugging * riscv hacks * config added * change target platforms * fix merge * debugging issue with zephyr 2.5 * cleanup * testing * pass riscv64 * fix merge * small fix * update vm_name * add zephyr version * add comment for riscv32 issue * remove debug messages * cleanup * cleanup * change workspace * fix zephyr version * cleanup * change to symlink * fix flag * add comment * lint check * lint fix * fix format * rename debugger * rework args Co-authored-by: Mehrdad Hessar <[email protected]> Co-authored-by: Andrew Reusch <[email protected]>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…7804) * working on qemu * debugging * riscv hacks * config added * change target platforms * fix merge * debugging issue with zephyr 2.5 * cleanup * working on qemu * debugging * riscv hacks * config added * change target platforms * fix merge * debugging issue with zephyr 2.5 * cleanup * testing * pass riscv64 * fix merge * small fix * update vm_name * add zephyr version * add comment for riscv32 issue * remove debug messages * cleanup * cleanup * change workspace * fix zephyr version * cleanup * change to symlink * fix flag * add comment * lint check * lint fix * fix format * rename debugger * rework args Co-authored-by: Mehrdad Hessar <[email protected]> Co-authored-by: Andrew Reusch <[email protected]>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…7804) * working on qemu * debugging * riscv hacks * config added * change target platforms * fix merge * debugging issue with zephyr 2.5 * cleanup * working on qemu * debugging * riscv hacks * config added * change target platforms * fix merge * debugging issue with zephyr 2.5 * cleanup * testing * pass riscv64 * fix merge * small fix * update vm_name * add zephyr version * add comment for riscv32 issue * remove debug messages * cleanup * cleanup * change workspace * fix zephyr version * cleanup * change to symlink * fix flag * add comment * lint check * lint fix * fix format * rename debugger * rework args Co-authored-by: Mehrdad Hessar <[email protected]> Co-authored-by: Andrew Reusch <[email protected]>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…7804) * working on qemu * debugging * riscv hacks * config added * change target platforms * fix merge * debugging issue with zephyr 2.5 * cleanup * working on qemu * debugging * riscv hacks * config added * change target platforms * fix merge * debugging issue with zephyr 2.5 * cleanup * testing * pass riscv64 * fix merge * small fix * update vm_name * add zephyr version * add comment for riscv32 issue * remove debug messages * cleanup * cleanup * change workspace * fix zephyr version * cleanup * change to symlink * fix flag * add comment * lint check * lint fix * fix format * rename debugger * rework args Co-authored-by: Mehrdad Hessar <[email protected]> Co-authored-by: Andrew Reusch <[email protected]>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…7804) * working on qemu * debugging * riscv hacks * config added * change target platforms * fix merge * debugging issue with zephyr 2.5 * cleanup * working on qemu * debugging * riscv hacks * config added * change target platforms * fix merge * debugging issue with zephyr 2.5 * cleanup * testing * pass riscv64 * fix merge * small fix * update vm_name * add zephyr version * add comment for riscv32 issue * remove debug messages * cleanup * cleanup * change workspace * fix zephyr version * cleanup * change to symlink * fix flag * add comment * lint check * lint fix * fix format * rename debugger * rework args Co-authored-by: Mehrdad Hessar <[email protected]> Co-authored-by: Andrew Reusch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds following changes:
Note: test_zephyr.py fully passes on qemu_riscv64 using the zephyr 2.5. However, for qemu_riscv32 you need to update zephyr to latest master branch. This issue is mentioned on zephyr: zephyrproject-rtos/zephyr#34026
We will update this when we update our zephyr to next version.