Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Metal accuracy problem caused by <dtype>3 vectors usage #7830

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Fix Metal accuracy problem caused by <dtype>3 vectors usage #7830

merged 1 commit into from
Apr 13, 2021

Commits on Apr 13, 2021

  1. Fix Metal accuracy problem caused by <dtype>3 vectors usage 

    On example of float3 datatype:
Using of float3 data type for loading of data cuncurrently into dense array shared
between all threads in Metal threading group can lead to data race between threads.
float3 datatype has size and and alignment eq to 16 bytes while kernel assumes to
copy 12 bytes in arbitrary not aligned places.
Using of packed_float3 datatypes solves the issue
    @elvin-n
    elvin-n committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    b483dda View commit details
    Browse the repository at this point in the history