Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Make input shape immutable #7844

Merged
merged 1 commit into from
Apr 14, 2021
Merged

[ONNX] Make input shape immutable #7844

merged 1 commit into from
Apr 14, 2021

Conversation

ymwangg
Copy link
Contributor

@ymwangg ymwangg commented Apr 14, 2021

I noticed the input shape can be mutated by relay.frontend.from_onnx.

mbrookhart
mbrookhart approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for noticing!

I think it's probably one of those cases where jumping back and forth between python and C++ can make it hard to remember where you get a copy and where you get a reference.

@mbrookhart mbrookhart merged commit 3673cab into apache:main Apr 14, 2021
@mbrookhart
Copy link
Contributor

Thanks @ymwangg!

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@ymwangg
[ONNX] Make input shape immutable (apache#7844)
eda04e1 
Co-authored-by: Yanming Wang <[email protected]>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@ymwangg
[ONNX] Make input shape immutable (apache#7844)
c8e3bef 
Co-authored-by: Yanming Wang <[email protected]>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@ymwangg
[ONNX] Make input shape immutable (apache#7844)
1f051c2 
Co-authored-by: Yanming Wang <[email protected]>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
@ymwangg @trevor-m
[ONNX] Make input shape immutable (apache#7844)
c244620 
Co-authored-by: Yanming Wang <[email protected]>
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookhart mbrookhart mbrookhart approved these changes

Assignees
No one assigned
Labels
status: review in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ymwangg @mbrookhart @ZihengJiang