Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPC][REFACTOR] Use PopenWorker to handle RPC Server. #7889

Merged
merged 1 commit into from
Apr 20, 2021
Merged

[RPC][REFACTOR] Use PopenWorker to handle RPC Server. #7889

merged 1 commit into from
Apr 20, 2021

Commits on Apr 20, 2021

  1. [RPC][REFACTOR] Use PopenWorker to handle RPC Server. 

    Previously the rpc server relies multiprocessing to start a new process and does not work under jupyter.
It also have a popen mode that does ensure the socket start listening before returning the port number.

This PR switches the implementations use PopenWorker. The port number is returned after the socket
get binded, which resolves some of the RPC flaky issues(need sleep to wait the server to start).
It also makes the RPC server jupyter friendly.
    @tqchen
    tqchen committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    c361651 View commit details
    Browse the repository at this point in the history