[BYOC][TensorRT] Fixes for explicit batch mode, Support reduce to scalar, Support split op #7967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@comaniac Could you please take a look? |
added 2 commits
May 3, 2021 21:45
|
Thanks @trevor-m |
umangyadav
pushed a commit
to umangyadav/tvm
that referenced
this pull request
May 5, 2021
…lar, Support split op (apache#7967)
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…lar, Support split op (apache#7967)
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…lar, Support split op (apache#7967)
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…lar, Support split op (apache#7967)
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…lar, Support split op (apache#7967)
apivovarov
reviewed
Apr 27, 2022
| @@ -723,6 +723,53 @@ class ConcatOpConverter : public TensorRTOpConverter { | |||
| } | |||
| }; | |||
|
|
|||
| class SplitOpConverter : public TensorRTOpConverter { | |||
There was a problem hiding this comment.
We should add #if TRT_VERSION_GE(5, 1, 5) before it because the code uses params->network->addSlice.
apivovarov
reviewed
Apr 27, 2022
| @@ -1072,6 +1127,7 @@ GetOpConverters() { | |||
| map->emplace("expand_dims", std::make_shared<ExpandDimsOpConverter>()); | |||
| map->emplace("squeeze", std::make_shared<SqueezeOpConverter>()); | |||
| map->emplace("concatenate", std::make_shared<ConcatOpConverter>()); | |||
| map->emplace("split", std::make_shared<SplitOpConverter>()); | |||
There was a problem hiding this comment.
It should go inside #if TRT_VERSION_GE(5, 1, 5) block below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some bug fixes and new features for TRT BYOC.
use_implicit_batch=False).