[METAL] Fix codegen for inf and erf #8054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Metal codegen with using `inf` constant. Constant `INFINITY` is used now instead of `inf`. Also, Metal doesn't have `erf` built-in function. So, we are using `fast_erf` from tir. User will see warning message when we will generate `fast_erf` instead of `erf`.
apeskov
reviewed
May 17, 2021
masahi
approved these changes
May 17, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
* [METAL] Fix codegen for inf and erf Fixed Metal codegen with using `inf` constant. Constant `INFINITY` is used now instead of `inf`. Also, Metal doesn't have `erf` built-in function. So, we are using `fast_erf` from tir. User will see warning message when we will generate `fast_erf` instead of `erf`. * Apply comments * Fix clang-format * Fix lint
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
* [METAL] Fix codegen for inf and erf Fixed Metal codegen with using `inf` constant. Constant `INFINITY` is used now instead of `inf`. Also, Metal doesn't have `erf` built-in function. So, we are using `fast_erf` from tir. User will see warning message when we will generate `fast_erf` instead of `erf`. * Apply comments * Fix clang-format * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Metal codegen with using
infconstant. ConstantINFINITYisused now instead of
inf.Also, Metal doesn't have
erfbuilt-in function. So, we are usingfast_erffrom tir. User will see warning message when we willgenerate
fast_erfinstead oferf.Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.