Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend, Tensorflow, Tensorflow2] Tensorflow frontend op refactor #8179

Merged
merged 6 commits into from
Jun 10, 2021

Conversation

rohanmukh
Copy link
Contributor

@rohanmukh rohanmukh commented Jun 2, 2021

This PR refactors the current tensorflow.py parser and separates the code for the ops into a separate file tensorflow_ops.py. The new parser for handling tensorflow2 models in TVM, ie tensorflow2.py, imports the existing frontend op codes from tensorflow.py. With the current PR both of these frontend codes will import the ops from a common file for the ops in tensorflow_ops.py.

This PR is in line with the original plan of supporting tensorflow2 parser in TVM frontend as in the discussion #4102 Exact commit plan here.

Co-authored-by: Rohan Mukherjee [email protected]
Co-authored-by: Xingyu Zhou [email protected]
Co-authored-by: David Huang [email protected]
Co-authored-by: Srinidhi Goud [email protected]
Co-authored-by: Xiao [email protected]

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

rohanmukh and others added 2 commits June 8, 2021 02:28
Co-authored-by: Rohan Mukherjee <[email protected]>
Co-authored-by: David Huang <[email protected]>
Co-authored-by: Xingyu Zhou <[email protected]>
Co-authored-by: Srinidhi Goud <[email protected]>
Co-authored-by: Xiao <[email protected]>
Co-authored-by: Xingyu Zhou <[email protected]>
Co-authored-by: Rohan Mukherjee <[email protected]>
Co-authored-by: David Huang <[email protected]>
Co-authored-by: Srinidhi Goud <[email protected]>
Co-authored-by: Xiao <[email protected]>
@rohanmukh rohanmukh changed the title [WIP][Frontend]Tensorflow op refactor [Tensorflow2, Frontend]Tensorflow op refactor Jun 8, 2021
@rohanmukh rohanmukh marked this pull request as ready for review June 8, 2021 06:03
@rohanmukh rohanmukh changed the title [Tensorflow2, Frontend]Tensorflow op refactor [Frontend, Tensorflow, Tensorflow2] Tensorflow frontend op refactor Jun 8, 2021
rohanmukh and others added 2 commits June 8, 2021 18:24
Author: Masahiro Masuda <[email protected]>

Co-authored-by: Masahiro Masuda <[email protected]>
Co-authored-by: Rohan Mukherjee <[email protected]>
Co-authored-by: Xingyu Zhou <[email protected]>
Co-authored-by: David Huang <[email protected]>
Co-authored-by: Srinidhi Goud <[email protected]>
Co-authored-by: Xiao <[email protected]>
@rohanmukh
Copy link
Contributor Author

@rohanmukh
Copy link
Contributor Author

Copy link
Contributor

@trevor-m trevor-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrozenGene FrozenGene merged commit 34e9a4f into apache:main Jun 10, 2021
@FrozenGene
Copy link
Member

Thanks @rohanmukh @trevor-m TF2 is one important frontend for TVM users. Great work and let us go on!

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
…pache#8179)

* Refactoring the ops from Tf1 frontend

Co-authored-by: Rohan Mukherjee <[email protected]>
Co-authored-by: David Huang <[email protected]>
Co-authored-by: Xingyu Zhou <[email protected]>
Co-authored-by: Srinidhi Goud <[email protected]>
Co-authored-by: Xiao <[email protected]>

* Resolving an import bug and refactor

Co-authored-by: Xingyu Zhou <[email protected]>
Co-authored-by: Rohan Mukherjee <[email protected]>
Co-authored-by: David Huang <[email protected]>
Co-authored-by: Srinidhi Goud <[email protected]>
Co-authored-by: Xiao <[email protected]>

* Tf2 frontend importing from common ops

* linting and unused imports fix

* Applying changes from commit id f4ec5fd

Author: Masahiro Masuda <[email protected]>

Co-authored-by: Masahiro Masuda <[email protected]>

* Minor linting

Co-authored-by: Rohan Mukherjee <[email protected]>
Co-authored-by: Xingyu Zhou <[email protected]>
Co-authored-by: David Huang <[email protected]>
Co-authored-by: Srinidhi Goud <[email protected]>
Co-authored-by: Xiao <[email protected]>

Co-authored-by: David Huang <[email protected]>
Co-authored-by: Xingyu Zhou <[email protected]>
Co-authored-by: Srinidhi Goud <[email protected]>
Co-authored-by: Xiao <[email protected]>
Co-authored-by: Masahiro Masuda <[email protected]>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
…pache#8179)

* Refactoring the ops from Tf1 frontend

Co-authored-by: Rohan Mukherjee <[email protected]>
Co-authored-by: David Huang <[email protected]>
Co-authored-by: Xingyu Zhou <[email protected]>
Co-authored-by: Srinidhi Goud <[email protected]>
Co-authored-by: Xiao <[email protected]>

* Resolving an import bug and refactor

Co-authored-by: Xingyu Zhou <[email protected]>
Co-authored-by: Rohan Mukherjee <[email protected]>
Co-authored-by: David Huang <[email protected]>
Co-authored-by: Srinidhi Goud <[email protected]>
Co-authored-by: Xiao <[email protected]>

* Tf2 frontend importing from common ops

* linting and unused imports fix

* Applying changes from commit id f4ec5fd

Author: Masahiro Masuda <[email protected]>

Co-authored-by: Masahiro Masuda <[email protected]>

* Minor linting

Co-authored-by: Rohan Mukherjee <[email protected]>
Co-authored-by: Xingyu Zhou <[email protected]>
Co-authored-by: David Huang <[email protected]>
Co-authored-by: Srinidhi Goud <[email protected]>
Co-authored-by: Xiao <[email protected]>

Co-authored-by: David Huang <[email protected]>
Co-authored-by: Xingyu Zhou <[email protected]>
Co-authored-by: Srinidhi Goud <[email protected]>
Co-authored-by: Xiao <[email protected]>
Co-authored-by: Masahiro Masuda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants