Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] [tir] do not simplify 'Any() - Any()' to 0 #8266

Merged
merged 4 commits into from
Jul 17, 2021
Merged

[Bugfix] [tir] do not simplify 'Any() - Any()' to 0 #8266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d28859d
fix
hgt312 Jun 16, 2021
60fb0d3
fix lint
hgt312 Jun 18, 2021
6cc86c8
remove
hgt312 Jun 21, 2021
b720a82
address comments
hgt312 Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/tvm/tir/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,7 +1190,7 @@ def __init__(self, var, value, body, span=None):


@tvm._ffi.register_object("tir.Any")
class Any(PrimExpr):
class Any(PrimExprWithOp):
"""Any node.

span : Optional[Span]
Expand Down
3 changes: 3 additions & 0 deletions src/tir/analysis/deep_equal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ bool ExprDeepEqual::operator()(const PrimExpr& lhs, const PrimExpr& rhs) const {
auto* prhs = rhs.as<IntImmNode>();
return plhs->dtype == prhs->dtype && plhs->value == prhs->value;
}
if (lhs.as<AnyNode>()) {
return false;
}
return DeepCmpSEqualHandler().SEqualReduce(lhs, rhs, false);
}

Expand Down
3 changes: 3 additions & 0 deletions tests/python/unittest/test_arith_rewrite_simplify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ def test_add_index_simplify():
def test_sub_index_simplify():
ck = RewriteChecker()
x, y, z = te.var("x"), te.var("y"), te.var("z")
a, b = tvm.tir.Any(), tvm.tir.Any()

ck.verify(x + y - y, x)
ck.verify(x + y - x, y)
Expand All @@ -293,6 +294,8 @@ def test_sub_index_simplify():

# mul co-efficient foldng
ck.verify(x - x, 0)
ck.verify(a - a, 0)
ck.verify(a - b, a - b)
ck.verify(x * y - x, x * (y + (-1)))
ck.verify(x * y - 10 * x, x * (y + (-10)))
ck.verify(y * x - x * z, x * (y - z))
Expand Down