DeviceType enums match dlpack #8407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwfromm 👋 |
|
Looks like the CI is failing due to flakiness. @schell would you mind push an empty commit to retrigger the CI? Thanks a lot! |
|
Looks like it ran successfully. Now this just needs a stamp of some type. |
junrushao
approved these changes
Jul 16, 2021
|
Thanks @schell @YuchenJin! It is merged |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* DeviceType enums match dlpack * intentionally left blank
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
* DeviceType enums match dlpack * intentionally left blank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jroesch I've updated the rust
DeviceTypeenum to match dlpack's definition here: https://github.com/dmlc/dlpack/blob/277508879878e0a5b5b43599b1bea11f66eb3c6c/include/dlpack/dlpack.h#L38-L71