[TOPI] Add support for arbitrary dtypes to CSRMV and CSRMM #8437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ANSHUMAN87
reviewed
Jul 10, 2021
| @@ -212,14 +210,15 @@ def check_device(device): | |||
|
|
|||
|
|
|||
| def test_csrmv(): | |||
| verify_dynamic_csrmv(batch=5, in_dim=7, out_dim=1, use_bias=False) | |||
| verify_dynamic_csrmv(batch=5, in_dim=7, out_dim=1, use_bias=True) | |||
| verify_dynamic_csrmv(batch=5, in_dim=7, out_dim=1, dtype="float32", use_bias=False) | |||
There was a problem hiding this comment.
As both are 2 diff op, I would suggest to maintain uniformity in Data type input for both the cases.
There was a problem hiding this comment.
This tests both dtype and use_bias at the same time. I'm trying to avoid adding too much testing overhead. If necessary, I can split it.
There was a problem hiding this comment.
I meant to add same datatype test cases for both. Please choose to ignore, it is minor. 👍
ANSHUMAN87
approved these changes
Jul 10, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8406
@mbrookhart @masahi