Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend][Tensorflow2] Stridedslice and concat_v2 fix #8483

Merged
merged 4 commits into from
Jul 17, 2021

Conversation

srinidhigoud
Copy link
Contributor

Strided_slice: In case of shrink axis, we need slice of a length one. And the slicing should start from m_begin[final_index]. So this change corrects it accordingly

concat_v2: This fix handles when there is an attribute error in the op

@srinidhigoud srinidhigoud changed the title Stridedslice and concat_v2 fix [Frontend][Tensorflow2] Stridedslice and concat_v2 fix Jul 15, 2021
@srinidhigoud
Copy link
Contributor Author

Copy link
Contributor

@trevor-m trevor-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Is it possible to add a unit test for the ConcatV2 fix?

@masahi masahi merged commit c95d16e into apache:main Jul 17, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* fix for strided_slice when begin > end in case of shrinkaxis_mask

* fix for name_hint missing error for concat_v2 op

* removing a local fix

* adding more testing capability to concat_v2
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
* fix for strided_slice when begin > end in case of shrinkaxis_mask

* fix for name_hint missing error for concat_v2 op

* removing a local fix

* adding more testing capability to concat_v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants